netdev - Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: Allow 100M speed for E825C SGMII device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d07597a8-7e89-41b3-aec9-3af9d9aed529@molgen.mpg.de>
Date: Fri, 21 Feb 2025 15:34:00 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Grzegorz Nitka <grzegorz.nitka@...el.com>,
 intel-wired-lan@...ts.osuosl.org
Cc: Aleksandr Loktionov <aleksandr.loktionov@...el.com>,
 netdev@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] ice: Allow 100M speed for
 E825C SGMII device

Dear Grzegorz,


Thank you for the patch.

Am 21.02.25 um 11:16 schrieb Grzegorz Nitka:
> Add E825C 10GbE SGMII device to the list of devices supporting 100Mbit
> link mode. Without that change, 100Mbit link mode is ignored in ethtool
> interface. This change was missed while adding the support for E825C
> devices family.

I always like to have the commands and output for reproducing the issue 
in the commit message. That way, people hitting the error, have a chance 
of finding the commit, for example, with search engines.

> Fixes: f64e189442332 ("ice: introduce new E825C devices family")
> Signed-off-by: Grzegorz Nitka <grzegorz.nitka@...el.com>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> ---
>   drivers/net/ethernet/intel/ice/ice_common.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
> index 7a2a2e8da8fa..caf3af2a32c3 100644
> --- a/drivers/net/ethernet/intel/ice/ice_common.c
> +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> @@ -3180,6 +3180,7 @@ bool ice_is_100m_speed_supported(struct ice_hw *hw)
>   	case ICE_DEV_ID_E822L_SGMII:
>   	case ICE_DEV_ID_E823L_1GBE:
>   	case ICE_DEV_ID_E823C_SGMII:
> +	case ICE_DEV_ID_E825C_SGMII:
>   		return true;
>   	default:
>   		return false;
Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul