netdev - Re: [PATCH *-next 00/18] Remove weird and needless 'return' for void APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5d662c4c-76f7-4e5c-82f3-2aeeaf9e3311@app.fastmail.com>
Date: Fri, 21 Feb 2025 16:40:58 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Zijun Hu" <quic_zijuhu@...cinc.com>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Will Deacon" <will@...nel.org>,
 "Aneesh Kumar K.V" <aneesh.kumar@...nel.org>,
 "Andrew Morton" <akpm@...ux-foundation.org>,
 "Nicholas Piggin" <npiggin@...il.com>,
 "Peter Zijlstra" <peterz@...radead.org>,
 "Thomas Gleixner" <tglx@...utronix.de>,
 "Herbert Xu" <herbert@...dor.apana.org.au>,
 "David S . Miller" <davem@...emloft.net>,
 "Rafael J . Wysocki" <rafael@...nel.org>,
 "Danilo Krummrich" <dakr@...nel.org>,
 "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Paolo Abeni" <pabeni@...hat.com>, "Simon Horman" <horms@...nel.org>,
 "Johannes Berg" <johannes@...solutions.net>,
 "Jamal Hadi Salim" <jhs@...atatu.com>,
 "Cong Wang" <xiyou.wangcong@...il.com>, "Jiri Pirko" <jiri@...nulli.us>,
 "Jason Gunthorpe" <jgg@...pe.ca>, "Leon Romanovsky" <leon@...nel.org>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "Bartosz Golaszewski" <brgl@...ev.pl>, "Lee Jones" <lee@...nel.org>,
 "Thomas Graf" <tgraf@...g.ch>, "Christoph Hellwig" <hch@....de>,
 "Marek Szyprowski" <m.szyprowski@...sung.com>,
 "Robin Murphy" <robin.murphy@....com>,
 "Miquel Raynal" <miquel.raynal@...tlin.com>,
 "Richard Weinberger" <richard@....at>,
 "Vignesh Raghavendra" <vigneshr@...com>
Cc: "Zijun Hu" <zijun_hu@...oud.com>, Linux-Arch <linux-arch@...r.kernel.org>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 linux-crypto@...r.kernel.org, Netdev <netdev@...r.kernel.org>,
 linux-wireless@...r.kernel.org, linux-rdma@...r.kernel.org,
 "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
 linux-pm@...r.kernel.org, iommu@...ts.linux.dev,
 linux-mtd@...ts.infradead.org
Subject: Re: [PATCH *-next 00/18] Remove weird and needless 'return' for void APIs

On Fri, Feb 21, 2025, at 14:02, Zijun Hu wrote:
> This patch series is to remove weird and needless 'return' for
> void APIs under include/ with the following pattern:
>
> api_header.h:
>
> void api_func_a(...);
>
> static inline void api_func_b(...)
> {
> 	return api_func_a(...);
> }
>
> Remove the needless 'return' in api_func_b().
>
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>

I have no objection to the changes, but I think you should
describe the motivation for them beyond them being 'weird'.

Do these 'return' statements get in the way of some other
work you are doing? Is there a compiler warning you want
to enable to ensure they don't come back? Is this all of
the instances in the kernel or just the ones you found by
inspection?

    Arnd