netdev - Re: [PATCH *-next 00/18] Remove weird and needless 'return' for void APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9af9413b7ab41c6b2db5f862d0fa50e9de279d67.camel@sipsolutions.net>
Date: Fri, 21 Feb 2025 20:36:26 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Stephen Hemminger <stephen@...workplumber.org>, Zijun Hu
	 <quic_zijuhu@...cinc.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Will Deacon	
 <will@...nel.org>, "Aneesh Kumar K.V" <aneesh.kumar@...nel.org>, Andrew
 Morton	 <akpm@...ux-foundation.org>, Nick Piggin <npiggin@...il.com>, Peter
 Zijlstra	 <peterz@...radead.org>, Arnd Bergmann <arnd@...db.de>, Thomas
 Gleixner	 <tglx@...utronix.de>, Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>, "Rafael J. Wysocki"
 <rafael@...nel.org>, Danilo Krummrich	 <dakr@...nel.org>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski	 <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman	 <horms@...nel.org>, Jamal Hadi Salim
 <jhs@...atatu.com>, Cong Wang	 <xiyou.wangcong@...il.com>, Jiri Pirko
 <jiri@...nulli.us>, Jason Gunthorpe	 <jgg@...pe.ca>, Leon Romanovsky
 <leon@...nel.org>, Linus Walleij	 <linus.walleij@...aro.org>, Bartosz
 Golaszewski <brgl@...ev.pl>, Lee Jones	 <lee@...nel.org>, Thomas Graf
 <tgraf@...g.ch>, Christoph Hellwig <hch@....de>,  Marek Szyprowski
 <m.szyprowski@...sung.com>, Robin Murphy <robin.murphy@....com>, Miquel
 Raynal	 <miquel.raynal@...tlin.com>, Richard Weinberger <richard@....at>,
 Vignesh Raghavendra <vigneshr@...com>, Zijun Hu <zijun_hu@...oud.com>,
 linux-arch@...r.kernel.org, 	linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, 
	netdev@...r.kernel.org, linux-wireless@...r.kernel.org, 
	linux-rdma@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-pm@...r.kernel.org, 	iommu@...ts.linux.dev,
 linux-mtd@...ts.infradead.org
Subject: Re: [PATCH *-next 00/18] Remove weird and needless 'return' for
 void APIs

On Fri, 2025-02-21 at 11:00 -0800, Stephen Hemminger wrote:
> 
> Is this something that could be done with a coccinelle script?
> 

Almost enough to do this:

@@
identifier fn;
expression E;
@@
void fn(...)
{
...
-return
E;
}


It takes a long time to run though, and does some wrong things as well:
if the return is in the middle of the function, it still matches and
removes it erroneously.

johannes