netdev - Re: [PATCH net v2] selftests/net: big_tcp: return xfail on slow machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250224134430.GA2858114@kernel.org>
Date: Mon, 24 Feb 2025 13:44:30 +0000
From: Simon Horman <horms@...nel.org>
To: Pablo Martin Medrano <pablmart@...hat.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH net v2] selftests/net: big_tcp: return xfail on slow
 machines

On Wed, Feb 19, 2025 at 06:07:58PM +0100, Pablo Martin Medrano wrote:
> After debugging the following output for big_tcp.sh on a board:
> 
> CLI GSO | GW GRO | GW GSO | SER GRO
> on        on       on       on      : [PASS]
> on        off      on       off     : [PASS]
> off       on       on       on      : [FAIL_on_link1]
> on        on       off      on      : [FAIL_on_link1]
> 
> Davide Caratti found that by default the test duration 1s is too short
> in slow systems to reach the correct cwd size necessary for tcp/ip to
> generate at least one packet bigger than 65536 (matching the iptables
> match on length rule the test evaluates)
> 
> This skips (with xfail) the aforementioned failing combinations when
> KSFT_MACHINE_SLOW is set. For that the test has been modified to use
> facilities from net/lib.sh.
> 
> The new output for the test will look like this (example with a forced
> XFAIL)
> 
> Testing for BIG TCP:
>       CLI GSO | GW GRO | GW GSO | SER GRO
> TEST: on        on       on       on                    [ OK ]
> TEST: on        off      on       off                   [ OK ]
> TEST: off       on       on       on                    [XFAIL]
> 
> Changes in v2:
> - Don't break the loop and use lib.sh facilities (thanks Peter Machata)
> - Rephrased the subject from "longer netperf session on slow machines"
>   as the patch is not configuring a longer session but skipping
> - Added tags and SOB and the Fixes: hash (thank you Davide Caratti)
> - Link to v1: https://lore.kernel.org/all/b800a71479a24a4142542051636e980c3b547434.1739794830.git.pablmart@redhat.com/

Hi Pablo,

FWIIW, I think this can be moved to below the scissors ("---").

> Fixes: a19747c3b9b ("selftests: net: let big_tcp test cope with slow env")

Checkpatch complains that fixes tags should have 12 or more characters of
sha1 hash.

Fixes: a19747c3b9bf ("selftests: net: let big_tcp test cope with slow env")

Lastly, and most importantly, it seems that there is new feedback on a
predecessor of this patch, which probably needs to be addressed.

- Re: [PATCH net] selftests/net: big_tcp: longer netperf session on slow machines
  https://lore.kernel.org/all/20250221144408.784cc642@kernel.org/

> Suggested-by: Davide Caratti <dcaratti@...hat.com>
> Suggested-by: Petr Machata <petrm@...dia.com>
> Signed-off-by: Pablo Martin Medrano <pablmart@...hat.com>
> ---
>  tools/testing/selftests/net/big_tcp.sh | 21 ++++++++++-----------
>  1 file changed, 10 insertions(+), 11 deletions(-)

...