netdev - Re: mlx5: WARNING: register_netdevice_notifier_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250224185736.76447-1-kuniyu@amazon.com>
Date: Mon, 24 Feb 2025 10:57:36 -0800
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <leitao@...ian.org>
CC: <kernel-team@...a.com>, <netdev@...r.kernel.org>, <saeedm@...dia.com>,
	<tariqt@...dia.com>, <thevlad@...a.com>
Subject: Re: mlx5: WARNING: register_netdevice_notifier_dev_net

From: Breno Leitao <leitao@...ian.org>
Date: Mon, 24 Feb 2025 10:04:23 -0800
> Hello,
> 
> I've begun noticing these messages in version 6.14, and they persist in
> 6.14-rc4 as in 082ecbc71e9 (“Linux 6.14-rc4"). As I haven't found any
> reports about this issue, I'm bringing it to your attention.
> 
> 	WARNING: CPU: 25 PID: 849 at net/core/dev.c:2150 register_netdevice_notifier_dev_net (net/core/dev.c:2150)
> 	
> 	<TASK>
> 	? __warn (kernel/panic.c:242 kernel/panic.c:748)
> 	? register_netdevice_notifier_dev_net (net/core/dev.c:2150)
> 	? register_netdevice_notifier_dev_net (net/core/dev.c:2150)
> 	? report_bug (lib/bug.c:? lib/bug.c:219)
> 	? handle_bug (arch/x86/kernel/traps.c:285)
> 	? exc_invalid_op (arch/x86/kernel/traps.c:309)
> 	? asm_exc_invalid_op (./arch/x86/include/asm/idtentry.h:621)
> 	? register_netdevice_notifier_dev_net (net/core/dev.c:2150)
> 	19:02:13 ? register_netdevice_notifier_dev_net (./include/net/net_namespace.h:406 ./include/linux/netdevice.h:2663 net/core/dev.c:2144)
> 	mlx5e_mdev_notifier_event+0x9f/0xf0 mlx5_ib
> 	notifier_call_chain.llvm.12241336988804114627 (kernel/notifier.c:85)
> 	blocking_notifier_call_chain (kernel/notifier.c:380)
> 	mlx5_core_uplink_netdev_event_replay (drivers/net/ethernet/mellanox/mlx5/core/main.c:352)
> 	mlx5_ib_roce_init.llvm.12447516292400117075+0x1c6/0x550 mlx5_ib
> 	mlx5r_probe+0x375/0x6a0 mlx5_ib
> 	? kernfs_put (./include/linux/instrumented.h:96 ./include/linux/atomic/atomic-arch-fallback.h:2278 ./include/linux/atomic/atomic-instrumented.h:1384 fs/kernfs/dir.c:557)
> 	? auxiliary_match_id (drivers/base/auxiliary.c:174)
> 	? mlx5r_mp_remove+0x160/0x160 mlx5_ib
> 	really_probe (drivers/base/dd.c:? drivers/base/dd.c:658)
> 	driver_probe_device (drivers/base/dd.c:830)
> 	__driver_attach (drivers/base/dd.c:1217)
> 	bus_for_each_dev (drivers/base/bus.c:369)
> 	? driver_attach (drivers/base/dd.c:1157)
> 	bus_add_driver (drivers/base/bus.c:679)
> 	driver_register (drivers/base/driver.c:249)
> 	__auxiliary_driver_register (drivers/ba

Looks like my assumption was simply wrong...

I'll post a patch with this diff:

---8<---
diff --git a/net/core/dev.c b/net/core/dev.c
index 1b252e9459fd..70c01bd1799e 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2141,21 +2141,15 @@ int register_netdevice_notifier_dev_net(struct net_device *dev,
 					struct notifier_block *nb,
 					struct netdev_net_notifier *nn)
 {
-	struct net *net = dev_net(dev);
 	int err;
 
-	/* rtnl_net_lock() assumes dev is not yet published by
-	 * register_netdevice().
-	 */
-	DEBUG_NET_WARN_ON_ONCE(!list_empty(&dev->dev_list));
-
-	rtnl_net_lock(net);
-	err = __register_netdevice_notifier_net(net, nb, false);
+	rtnl_net_dev_lock(dev);
+	err = __register_netdevice_notifier_net(dev_net(dev), nb, false);
 	if (!err) {
 		nn->nb = nb;
 		list_add(&nn->list, &dev->net_notifier_list);
 	}
-	rtnl_net_unlock(net);
+	rtnl_net_dev_unlock(dev);
 
 	return err;
 }
---8<---

Thanks!