netdev - [PATCH net-next v8 7/8] net: selftests: Add selftests sets with fixed speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250224211531.115980-8-gerhard@engleder-embedded.com>
Date: Mon, 24 Feb 2025 22:15:30 +0100
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: andrew@...n.ch,
	hkallweit1@...il.com,
	linux@...linux.org.uk,
	davem@...emloft.net,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com
Cc: netdev@...r.kernel.org,
	Gerhard Engleder <gerhard@...leder-embedded.com>
Subject: [PATCH net-next v8 7/8] net: selftests: Add selftests sets with fixed speed

Add PHY loopback selftest set which uses the speed argument to select a
fixed speed.

Signed-off-by: Gerhard Engleder <gerhard@...leder-embedded.com>
---
 include/net/selftests.h |  2 ++
 net/core/selftests.c    | 46 ++++++++++++++++++++++++++++++++++++++---
 2 files changed, 45 insertions(+), 3 deletions(-)

diff --git a/include/net/selftests.h b/include/net/selftests.h
index e97aaebaf51a..d9450c0352a4 100644
--- a/include/net/selftests.h
+++ b/include/net/selftests.h
@@ -7,9 +7,11 @@
 /**
  * enum net_selftest - selftest set ID
  * @NET_SELFTEST_LOOPBACK_CARRIER: Loopback tests based on carrier speed
+ * @NET_SELFTEST_LOOPBACK_SPEED: Loopback tests with fixed speed
  */
 enum net_selftest {
 	NET_SELFTEST_LOOPBACK_CARRIER = 0,
+	NET_SELFTEST_LOOPBACK_SPEED,
 };
 
 #if IS_ENABLED(CONFIG_NET_SELFTESTS)
diff --git a/net/core/selftests.c b/net/core/selftests.c
index 4a7022a1e931..b6ad711136b4 100644
--- a/net/core/selftests.c
+++ b/net/core/selftests.c
@@ -16,6 +16,7 @@
 
 struct net_test_ctx {
 	u8 next_id;
+	int speed;
 };
 
 struct net_packet_attrs {
@@ -305,6 +306,16 @@ struct net_test {
 		.fn = net_test_##_name##_fn,	\
 	}
 
+/**
+ * NET_SELFTEST_LOOPBACK_SPEED - Define a selftest which enables loopback with a fixed speed.
+ * @_name: Selftest name.
+ */
+#define NET_SELFTEST_LOOPBACK_SPEED(_name)	\
+	struct net_test net_test_##_name = {	\
+		.fn = net_test_##_name##_fn,	\
+		.loopback_speed = true,		\
+	}
+
 static int net_test_netif_carrier_fn(struct net_test_ctx *ctx,
 				     struct net_device *ndev)
 {
@@ -332,6 +343,17 @@ static int net_test_phy_loopback_enable_fn(struct net_test_ctx *ctx,
 
 static const NET_SELFTEST(phy_loopback_enable, "PHY loopback enable");
 
+static int net_test_phy_loopback_speed_enable_fn(struct net_test_ctx *ctx,
+						 struct net_device *ndev)
+{
+	if (!ndev->phydev)
+		return -EOPNOTSUPP;
+
+	return phy_loopback(ndev->phydev, true, ctx->speed);
+}
+
+static const NET_SELFTEST_LOOPBACK_SPEED(phy_loopback_speed_enable);
+
 static int net_test_phy_loopback_disable_fn(struct net_test_ctx *ctx,
 					    struct net_device *ndev)
 {
@@ -388,11 +410,22 @@ static const struct net_test *net_selftests_carrier[] = {
 	&net_test_phy_loopback_disable,
 };
 
+static const struct net_test *net_selftests_speed[] = {
+	&net_test_phy_phydev,
+	&net_test_phy_loopback_speed_enable,
+	&net_test_phy_loopback_udp,
+	&net_test_phy_loopback_udp_mtu,
+	&net_test_phy_loopback_tcp,
+	&net_test_phy_loopback_disable,
+};
+
 static const struct net_test **net_selftests_set_get(int set)
 {
 	switch (set) {
 	case NET_SELFTEST_LOOPBACK_CARRIER:
 		return net_selftests_carrier;
+	case NET_SELFTEST_LOOPBACK_SPEED:
+		return net_selftests_speed;
 	}
 
 	return NULL;
@@ -403,7 +436,7 @@ void net_selftest_set(int set, int speed, struct net_device *ndev,
 {
 	const struct net_test **selftests = net_selftests_set_get(set);
 	int count = net_selftest_set_get_count(set);
-	struct net_test_ctx ctx = { 0 };
+	struct net_test_ctx ctx = { .speed = speed };
 	int i;
 
 	memset(buf, 0, sizeof(*buf) * count);
@@ -427,6 +460,8 @@ int net_selftest_set_get_count(int set)
 	switch (set) {
 	case NET_SELFTEST_LOOPBACK_CARRIER:
 		return ARRAY_SIZE(net_selftests_carrier);
+	case NET_SELFTEST_LOOPBACK_SPEED:
+		return ARRAY_SIZE(net_selftests_speed);
 	default:
 		return -EINVAL;
 	}
@@ -440,8 +475,13 @@ void net_selftest_set_get_strings(int set, int speed, u8 **data)
 	int i;
 
 	/* right pad strings for aligned ethtool output */
-	for (i = 0; i < count; i++)
-		ethtool_sprintf(data, "%-30s", selftests[i]->name);
+	for (i = 0; i < count; i++) {
+		if (selftests[i]->loopback_speed)
+			ethtool_sprintf(data, "PHY loopback %-17s",
+					phy_speed_to_str(speed));
+		else
+			ethtool_sprintf(data, "%-30s", selftests[i]->name);
+	}
 }
 EXPORT_SYMBOL_GPL(net_selftest_set_get_strings);
 
-- 
2.39.5