netdev - Re: [PATCH net] enic: Avoid removing IPv6 address when updating rings size.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250224131843.4ef2307d@kernel.org>
Date: Mon, 24 Feb 2025 13:18:43 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Mohammad Heib <mheib@...hat.com>
Cc: netdev@...r.kernel.org, benve@...co.com, satishkh@...co.com
Subject: Re: [PATCH net] enic: Avoid removing IPv6 address when updating
 rings size.

On Sun, 23 Feb 2025 23:42:03 +0200 Mohammad Heib wrote:
> To avoid this behavior, this patch temporarily sets the interface config
> `keep_addr_on_down` to 1 before closing the device during the rings
> update, and restores the original value of `keep_addr_on_down` after
> updating the device rings, this will prevent the ipv6 stack from
> removing the current ipv6 addresses during the rings update.

Wrong direction, you should support reconfiguration natively 
in the driver. Pre-allocate all the resources for the new config
and swap it with the running one.
-- 
pw-bot: cr