netdev - Re: [PATCH v26 07/20] nvme-tcp: RX DDGST offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d9340b1-02a5-4fa1-971e-a2a4baf77ef7@redhat.com>
Date: Tue, 25 Feb 2025 11:42:43 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Aurelien Aptel <aaptel@...dia.com>, linux-nvme@...ts.infradead.org,
 netdev@...r.kernel.org, sagi@...mberg.me, hch@....de, kbusch@...nel.org,
 axboe@...com, chaitanyak@...dia.com, davem@...emloft.net, kuba@...nel.org
Cc: Yoray Zack <yorayz@...dia.com>, aurelien.aptel@...il.com,
 smalin@...dia.com, malin1024@...il.com, ogerlitz@...dia.com,
 borisp@...dia.com, galshalom@...dia.com, mgurtovoy@...dia.com
Subject: Re: [PATCH v26 07/20] nvme-tcp: RX DDGST offload

On 2/21/25 10:52 AM, Aurelien Aptel wrote:
> @@ -420,6 +422,46 @@ nvme_tcp_get_ddp_netdev_with_limits(struct nvme_tcp_ctrl *ctrl)
>  	return NULL;
>  }
>  
> +static inline bool nvme_tcp_ddp_ddgst_ok(struct nvme_tcp_queue *queue)

'inline' functions should be avoided in c files. Either drop the inline
keyword or move the definition to a (local) include file.

Thanks,

Paolo