netdev - Re: [PATCH net-next] selftests/net: ensure mptcp is enabled in netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z725bDY9YJX8ydEu@fedora>
Date: Tue, 25 Feb 2025 12:37:00 +0000
From: Hangbin Liu <liuhangbin@...il.com>
To: Matthieu Baerts <matttbe@...nel.org>
Cc: Davide Caratti <dcaratti@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] selftests/net: ensure mptcp is enabled in netns

On Mon, Feb 24, 2025 at 02:53:13PM +0100, Matthieu Baerts wrote:
> Hi Hangbin, Davide,
> 
> On 24/02/2025 10:40, Hangbin Liu wrote:
> > Some distributions may not enable MPTCP by default. All other MPTCP tests
> > source mptcp_lib.sh to ensure MPTCP is enabled before testing. However,
> > the ip_local_port_range test is the only one that does not include this
> > step.
> 
> This modification is OK for me, but would it not be time to stop
> patching the kernel of these distributions to disable MPTCP by default?
> 
> As far as I know, only one Linux distribution is doing that, and that's
> the one supporting MPTCP the best :)

> It was making sense when MPTCP was backported to older kernels, but now
> that v6.12 is used as a new base, it probably no longer makes sense, no?

Hi Matthieu,

Thanks for your review. I can't control the decisions. I also hope
we don't need to do this in future :)

Regards
Hangbin
> 
> > Let's also ensure MPTCP is enabled in netns for ip_local_port_range so
> > that it passes on all distributions.
> 
> Acked-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>

> 
> Cheers,
> Matt
> -- 
> Sponsored by the NGI0 Core fund.
>