netdev - Re: [PATCH net-next] tcp: be less liberal in tsecr received while in SYN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKHzSQ9RnjeYzhP42gubGeHtjSTbK8METXOSA-NuSJTPQ@mail.gmail.com>
Date: Tue, 25 Feb 2025 13:55:22 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Matthieu Baerts <matttbe@...nel.org>
Cc: Paolo Abeni <pabeni@...hat.com>, Kuniyuki Iwashima <kuniyu@...zon.com>, 
	Simon Horman <horms@...nel.org>, Florian Westphal <fw@...len.de>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com, Jakub Kicinski <kuba@...nel.org>, 
	Yong-Hao Zou <yonghaoz1994@...il.com>, "David S . Miller" <davem@...emloft.net>, 
	Neal Cardwell <ncardwell@...gle.com>
Subject: Re: [PATCH net-next] tcp: be less liberal in tsecr received while in
 SYN_RECV state

On Tue, Feb 25, 2025 at 1:50 PM Eric Dumazet <edumazet@...gle.com> wrote:
ed to refine the patch and send a V2 later.
>
> In v2 I will no longer read req->num_timeout
>
> First SYNACK is sent with syn_skb being set.
>
> Subsequent RTX SYNACK have a NULL syn_skb :
>
> tcp_rtx_synack()
>
> res = af_ops->send_synack(sk, NULL, &fl, req, NULL, TCP_SYNACK_NORMAL, NULL);

No, because I have to take care of possible alloc_skb() failures in
tcp_make_synack()... this is a bit tricky.