netdev - Re: [PATCH v26 01/20] net: Introduce direct data placement tcp offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <253seo2ywq6.fsf@nvidia.com>
Date: Tue, 25 Feb 2025 15:34:09 +0200
From: Aurelien Aptel <aaptel@...dia.com>
To: Paolo Abeni <pabeni@...hat.com>, linux-nvme@...ts.infradead.org,
 netdev@...r.kernel.org, sagi@...mberg.me, hch@....de, kbusch@...nel.org,
 axboe@...com, chaitanyak@...dia.com, davem@...emloft.net, kuba@...nel.org
Cc: Boris Pismenny <borisp@...dia.com>, aurelien.aptel@...il.com,
 smalin@...dia.com, malin1024@...il.com, ogerlitz@...dia.com,
 yorayz@...dia.com, galshalom@...dia.com, mgurtovoy@...dia.com,
 edumazet@...gle.com, dsahern@...nel.org, ast@...nel.org,
 jacob.e.keller@...el.com
Subject: Re: [PATCH v26 01/20] net: Introduce direct data placement tcp offload

Paolo Abeni <pabeni@...hat.com> writes:
>> +     /* put in ulp_ddp_sk_del() */
>> +     dev_hold(netdev);
>
> You should use netdev_hold()/netdev_put() instead, with a paired reftracker.

Ok, we will pass the tracker as argument.

>>       flush |= (ntohl(th2->seq) + skb_gro_len(p)) ^ ntohl(th->seq);
>>       flush |= skb_cmp_decrypted(p, skb);
>> +     flush |= skb_is_ulp_crc(p) != skb_is_ulp_crc(skb);
>
> Possibly a `skb_cmp_ulp_crc()` helper would be cleaner.

Sure, we will make a skb_cmp_ulp_crc() helper.

Thanks