netdev - Re: [PATCH *-next 01/18] mm/mmu_gather: Remove needless return in void API tlb_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2298251.1740496596@warthog.procyon.org.uk>
Date: Tue, 25 Feb 2025 15:16:36 +0000
From: David Howells <dhowells@...hat.com>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
    Will Deacon <will@...nel.org>,
    "Aneesh Kumar K.V" <aneesh.kumar@...nel.org>,
    Andrew Morton <akpm@...ux-foundation.org>,
    Nick Piggin <npiggin@...il.com>, Arnd Bergmann <arnd@...db.de>,
    Thomas Gleixner <tglx@...utronix.de>,
    Herbert Xu <herbert@...dor.apana.org.au>,
    "David S. Miller" <davem@...emloft.net>,
    "Rafael J. Wysocki" <rafael@...nel.org>,
    Danilo Krummrich <dakr@...nel.org>,
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
    Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
    Johannes Berg <johannes@...solutions.net>,
    Jamal Hadi Salim <jhs@...atatu.com>,
    Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
    Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>,
    Linus Walleij <linus.walleij@...aro.org>,
    Bartosz Golaszewski <brgl@...ev.pl>, Lee Jones <lee@...nel.org>,
    Thomas Graf <tgraf@...g.ch>, Christoph Hellwig <hch@....de>,
    Marek Szyprowski <m.szyprowski@...sung.com>,
    Robin Murphy <robin.murphy@....com>,
    Miquel Raynal <miquel.raynal@...tlin.com>,
    Richard Weinberger <richard@....at>,
    Vignesh Raghavendra <vigneshr@...com>, linux-arch@...r.kernel.org,
    linux-mm@...ck.org, linux-kernel@...r.kernel.org,
    linux-crypto@...r.kernel.org, netdev@...r.kernel.org,
    linux-wireless@...r.kernel.org, linux-rdma@...r.kernel.org,
    linux-gpio@...r.kernel.org, linux-pm@...r.kernel.org,
    iommu@...ts.linux.dev, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH *-next 01/18] mm/mmu_gather: Remove needless return in void API tlb_remove_page()

Zijun Hu <zijun_hu@...oud.com> wrote:

> >>  static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page)
> >>  {
> >> -	return tlb_remove_page_size(tlb, page, PAGE_SIZE);
> >> +	tlb_remove_page_size(tlb, page, PAGE_SIZE);
> >>  }
> > So I don't mind removing it, but note that that return enforces
> > tlb_remove_page_size() has void return type.
> >
> 
> tlb_remove_page_size() is void function already. (^^)

That may be true... for now.  But if that is changed in the future, then you
will get an error indicating something you need to go and look at... so in
that regard, it's *better* to do this ;-)

David