netdev - RE: [PATCH bpf-next 1/6] selftests/xsk: Add packet stream replacement functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB65141726E8FBA7E01DA259EC8FC32@IA1PR11MB6514.namprd11.prod.outlook.com>
Date: Tue, 25 Feb 2025 15:57:50 +0000
From: "Vyavahare, Tushar" <tushar.vyavahare@...el.com>
To: Stanislav Fomichev <stfomichev@...il.com>
CC: "bpf@...r.kernel.org" <bpf@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "bjorn@...nel.org" <bjorn@...nel.org>, "Karlsson,
 Magnus" <magnus.karlsson@...el.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "jonathan.lemon@...il.com"
	<jonathan.lemon@...il.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"ast@...nel.org" <ast@...nel.org>, "daniel@...earbox.net"
	<daniel@...earbox.net>
Subject: RE: [PATCH bpf-next 1/6] selftests/xsk: Add packet stream replacement
 functions



> -----Original Message-----
> From: Stanislav Fomichev <stfomichev@...il.com>
> Sent: Thursday, February 20, 2025 11:16 PM
> To: Vyavahare, Tushar <tushar.vyavahare@...el.com>
> Cc: bpf@...r.kernel.org; netdev@...r.kernel.org; bjorn@...nel.org; Karlsson,
> Magnus <magnus.karlsson@...el.com>; Fijalkowski, Maciej
> <maciej.fijalkowski@...el.com>; jonathan.lemon@...il.com;
> davem@...emloft.net; kuba@...nel.org; pabeni@...hat.com; ast@...nel.org;
> daniel@...earbox.net
> Subject: Re: [PATCH bpf-next 1/6] selftests/xsk: Add packet stream replacement
> functions
> 
> On 02/20, Tushar Vyavahare wrote:
> > Add pkt_stream_replace function to replace the packet stream for a
> > given ifobject. Add pkt_stream_replace_both function to replace the
> > packet streams for both transmit and receive ifobject in test_spec.
> > Enhance test framework to handle packet stream replacements efficiently.
> >
> > Signed-off-by: Tushar Vyavahare <tushar.vyavahare@...el.com>
> > ---
> >  tools/testing/selftests/bpf/xskxceiver.c | 29
> > +++++++++++++-----------
> >  1 file changed, 16 insertions(+), 13 deletions(-)
> >
> > diff --git a/tools/testing/selftests/bpf/xskxceiver.c
> > b/tools/testing/selftests/bpf/xskxceiver.c
> > index 11f047b8af75..1d9b03666ee6 100644
> > --- a/tools/testing/selftests/bpf/xskxceiver.c
> > +++ b/tools/testing/selftests/bpf/xskxceiver.c
> > @@ -757,14 +757,15 @@ static struct pkt_stream *pkt_stream_clone(struct
> pkt_stream *pkt_stream)
> >  	return pkt_stream_generate(pkt_stream->nb_pkts,
> > pkt_stream->pkts[0].len);  }
> >
> > -static void pkt_stream_replace(struct test_spec *test, u32 nb_pkts,
> > u32 pkt_len)
> > +static void pkt_stream_replace(struct ifobject *ifobj, u32 nb_pkts,
> > +u32 pkt_len)
> >  {
> > -	struct pkt_stream *pkt_stream;
> > +	ifobj->xsk->pkt_stream = pkt_stream_generate(nb_pkts, pkt_len); }
> >
> > -	pkt_stream = pkt_stream_generate(nb_pkts, pkt_len);
> > -	test->ifobj_tx->xsk->pkt_stream = pkt_stream;
> > -	pkt_stream = pkt_stream_generate(nb_pkts, pkt_len);
> > -	test->ifobj_rx->xsk->pkt_stream = pkt_stream;
> 
> [..]
> 
> > +static void pkt_stream_replace_both(struct test_spec *test, u32
> > +nb_pkts, u32 pkt_len) {
> > +	pkt_stream_replace(test->ifobj_tx, nb_pkts, pkt_len);
> > +	pkt_stream_replace(test->ifobj_rx, nb_pkts, pkt_len);
> >  }
> 
> nit: maybe keep existing name pkt_stream_replace here? and add new helper
> pkt_stream_replace_ifobject to work on particular ifobject?
> 

Will do. Thank you.

> static void pkt_stream_replace_both(struct test_spec *test, u32 nb_pkts, u32
> pkt_len) {
> 	pkt_stream_replace_ifobject(test->ifobj_tx, nb_pkts, pkt_len);
> 	pkt_stream_replace_ifobject(test->ifobj_rx, nb_pkts, pkt_len); }
> 
> This should avoid touching existing call sites.