netdev - Re: [PATCH net-next v3] eth: fbnic: support TCP segmentation offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z736uO_DiO1fkn53@LQ3V64L9R2>
Date: Tue, 25 Feb 2025 12:15:36 -0500
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	alexanderduyck@...com
Subject: Re: [PATCH net-next v3] eth: fbnic: support TCP segmentation offload

On Sun, Feb 16, 2025 at 09:41:09AM -0800, Jakub Kicinski wrote:
> Add TSO support to the driver. Device can handle unencapsulated or
> IPv6-in-IPv6 packets. Any other tunnel stacks are handled with
> GSO partial.
> 
> Validate that the packet can be offloaded in ndo_features_check.
> Main thing we need to check for is that the header geometry can
> be expressed in the decriptor fields (offsets aren't too large).
> 
> Report number of TSO super-packets via the qstat API.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> v3:
>  - add missing feature clearing in ndo_features_check
> v2: https://lore.kernel.org/20250214235207.2312352-1-kuba@kernel.org
>  - checkpatch -> whitespace
> v1: https://lore.kernel.org/20250213005540.1345735-1-kuba@kernel.org
> 
> CC: alexanderduyck@...com
> CC: jdamato@...tly.com
> ---
>  .../net/ethernet/meta/fbnic/fbnic_netdev.h    |   3 +
>  drivers/net/ethernet/meta/fbnic/fbnic_txrx.h  |   1 +
>  .../net/ethernet/meta/fbnic/fbnic_netdev.c    |  25 ++-
>  drivers/net/ethernet/meta/fbnic/fbnic_txrx.c  | 146 +++++++++++++++++-
>  4 files changed, 163 insertions(+), 12 deletions(-)

Scanned through this change a few times and nothing obvious stood
out to me, but I'm not super familiar with this driver (despite
being CC'd :P):

Acked-by: Joe Damato <jdamato@...tly.com>