netdev - Re: [PATCH v26 01/20] net: Introduce direct data placement tcp offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <253mseaymgi.fsf@nvidia.com>
Date: Tue, 25 Feb 2025 19:15:57 +0200
From: Aurelien Aptel <aaptel@...dia.com>
To: Paolo Abeni <pabeni@...hat.com>, linux-nvme@...ts.infradead.org,
 netdev@...r.kernel.org, sagi@...mberg.me, hch@....de, kbusch@...nel.org,
 axboe@...com, chaitanyak@...dia.com, davem@...emloft.net, kuba@...nel.org,
 apw@...onical.com, joe@...ches.com, dwaipayanray1@...il.com,
 lukas.bulwahn@...il.com
Cc: Boris Pismenny <borisp@...dia.com>, aurelien.aptel@...il.com,
 smalin@...dia.com, malin1024@...il.com, ogerlitz@...dia.com,
 yorayz@...dia.com, galshalom@...dia.com, mgurtovoy@...dia.com,
 edumazet@...gle.com, dsahern@...nel.org, ast@...nel.org,
 jacob.e.keller@...el.com
Subject: Re: [PATCH v26 01/20] net: Introduce direct data placement tcp offload


Aurelien Aptel <aaptel@...dia.com> writes:
> Paolo Abeni <pabeni@...hat.com> writes:
>>> +     /* put in ulp_ddp_sk_del() */
>>> +     dev_hold(netdev);
>>
>> You should use netdev_hold()/netdev_put() instead, with a paired reftracker.
>
> Ok, we will pass the tracker as argument.

There is currently a bug in checkpatch, it seems it cannot deal with kernel
typedefs when they are inside a ifdef:

    $ cat > test.h
    /* SPDX-License-Identifier: MIT */
    #if x
    int a(netdevice_tracker *p);
    #endif
    ^D

    $ ./scripts/checkpatch.pl -f test.h
    ERROR: need consistent spacing around '*' (ctx:WxV)
    #3: FILE: test.h:3:
    +int a(netdevice_tracker *p);
                             ^
    
    total: 1 errors, 0 warnings, 4 lines checked
    
    NOTE: For some of the reported defects, checkpatch may be able to
          mechanically convert to the typical style using --fix or --fix-inplace.
    
    test.h has style problems, please review.
    
    NOTE: If any of the errors are false positives, please report
          them to the maintainer, see CHECKPATCH in MAINTAINERS.


If you remove the #if/#endif it is quiet.

I'm reporting this since NIPA is so strict on checkpatch errors.
I've added checkpatch.pl maintainers in the loop.
In the meantime maybe let's ignore this warning in NIPA?

Thanks