netdev - Re: [PATCH net-next 1/1] enic: add dependency on Page Pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z702TLsTKDIvTQN_@LQ3V64L9R2>
Date: Mon, 24 Feb 2025 22:17:32 -0500
From: Joe Damato <jdamato@...tly.com>
To: John Daley <johndale@...co.com>
Cc: benve@...co.com, satishkh@...co.com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	kernel test robot <lkp@...el.com>,
	Nelson Escobar <neescoba@...co.com>
Subject: Re: [PATCH net-next 1/1] enic: add dependency on Page Pool

On Mon, Feb 24, 2025 at 03:43:50PM -0800, John Daley wrote:
> Driver was not configured to select page_pool, causing a compile error
> if page pool module was not already selected.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502211253.3XRosM9I-lkp@intel.com/
> Fixes: d24cb52b2d8a ("enic: Use the Page Pool API for RX")
> Reviewed-by: Nelson Escobar <neescoba@...co.com>
> Signed-off-by: John Daley <johndale@...co.com>
> ---
>  drivers/net/ethernet/cisco/enic/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Hrm. This is a fixes, so normally the subject line should probably
be "PATCH net" instead of "PATCH net-next" and stable would be CC'd
- however - it looks like the commit it fixes is only in net-next.

So, CC-ing stable is probably unnecessary ?

At any rate, I'd probably skip the cover letter for a simple patch
like this in the future.

Reviewed-by: Joe Damato <jdamato@...tly.com>