| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID:
<BY3PR18MB470765FAF7160544D7032C0FA0C32@BY3PR18MB4707.namprd18.prod.outlook.com>
Date: Tue, 25 Feb 2025 06:12:32 +0000
From: Sai Krishna Gajula <saikrishnag@...vell.com>
To: Paolo Abeni <pabeni@...hat.com>,
"davem@...emloft.net"
<davem@...emloft.net>,
"edumazet@...gle.com" <edumazet@...gle.com>,
"kuba@...nel.org" <kuba@...nel.org>,
"netdev@...r.kernel.org"
<netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>,
Sunil Kovvuri Goutham <sgoutham@...vell.com>,
Geethasowjanya Akula <gakula@...vell.com>,
Linu Cherian
<lcherian@...vell.com>, Jerin Jacob <jerinj@...vell.com>,
Hariprasad Kelam
<hkelam@...vell.com>,
Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
"kalesh-anakkur.purayil@...adcom.com" <kalesh-anakkur.purayil@...adcom.com>
Subject: Re: [net-next PATCH v10 3/6] octeontx2-af: CN20k mbox to support AF
REQ/ACK functionality
> -----Original Message-----
> From: Paolo Abeni <pabeni@...hat.com>
> Sent: Thursday, February 20, 2025 5:29 PM
> To: Sai Krishna Gajula <saikrishnag@...vell.com>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Sunil Kovvuri Goutham <sgoutham@...vell.com>;
> Geethasowjanya Akula <gakula@...vell.com>; Linu Cherian
> <lcherian@...vell.com>; Jerin Jacob <jerinj@...vell.com>; Hariprasad Kelam
> <hkelam@...vell.com>; Subbaraya Sundeep Bhatta <sbhatta@...vell.com>;
> andrew+netdev@...n.ch; kalesh-anakkur.purayil@...adcom.com
> Subject: Re: [net-next PATCH v10 3/6] octeontx2-af: CN20k mbox
> to support AF REQ/ACK functionality
>
> On 2/17/25 9: 52 AM, Sai Krishna wrote: > This implementation uses separate
> trigger interrupts for request, > response MBOX messages against using trigger
> message data in CN10K. > This patch adds support for basic mbox
> implementation
> On 2/17/25 9:52 AM, Sai Krishna wrote:
> > This implementation uses separate trigger interrupts for request,
> > response MBOX messages against using trigger message data in CN10K.
> > This patch adds support for basic mbox implementation for CN20K from
> > AF side.
> >
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@...vell.com>
> > Signed-off-by: Sai Krishna <saikrishnag@...vell.com>
> > ---
> > .../ethernet/marvell/octeontx2/af/cn20k/api.h | 8 +
> > .../marvell/octeontx2/af/cn20k/mbox_init.c | 215
> ++++++++++++++++++
> > .../ethernet/marvell/octeontx2/af/cn20k/reg.h | 17 ++
> > .../marvell/octeontx2/af/cn20k/struct.h | 25 ++
> > .../net/ethernet/marvell/octeontx2/af/mbox.c | 83 ++++++-
> > .../net/ethernet/marvell/octeontx2/af/mbox.h | 1 +
> > .../net/ethernet/marvell/octeontx2/af/rvu.c | 69 ++++--
> > .../net/ethernet/marvell/octeontx2/af/rvu.h | 16 +-
> > .../marvell/octeontx2/nic/otx2_common.c | 10 +-
> > .../ethernet/marvell/octeontx2/nic/otx2_pf.c | 9 +-
> > 10 files changed, 420 insertions(+), 33 deletions(-) create mode
> > 100644 drivers/net/ethernet/marvell/octeontx2/af/cn20k/struct.h
> >
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cn20k/api.h
> > b/drivers/net/ethernet/marvell/octeontx2/af/cn20k/api.h
> > index b57bd38181aa..9436a4a4d815 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/cn20k/api.h
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/cn20k/api.h
> > @@ -15,8 +15,16 @@ struct ng_rvu {
> > struct qmem *pf_mbox_addr;
> > };
> >
> > +struct rvu;
> > +
>
> A few lines above the header file rvu.h is included, the forward declararions
> should not be needed...
>
> > /* Mbox related APIs */
> > int cn20k_rvu_mbox_init(struct rvu *rvu, int type, int num);
>
> ... otherwise this line will give warns in the previous patch.
Ack, will submit v11 with updates.
>
> [...]
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > index 9f145c540253..acd9e1ca6d2b 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > @@ -597,8 +597,7 @@ static int otx2_pfvf_mbox_init(struct otx2_nic *pf,
> int numvfs)
> > base = pci_resource_start(pf->pdev, PCI_MBOX_BAR_NUM) +
> > MBOX_SIZE;
> > else
> > - base = readq((void __iomem *)((u64)pf->reg_base +
> > - RVU_PF_VF_BAR4_ADDR));
> > + base = readq((pf->reg_base + RVU_PF_VF_BAR4_ADDR));
> >
> > hwbase = ioremap_wc(base, MBOX_SIZE * pf->total_vfs);
> > if (!hwbase) {
> > @@ -647,7 +646,7 @@ static void otx2_pfvf_mbox_destroy(struct otx2_nic
> *pf)
> > }
> >
> > if (mbox->mbox.hwbase)
> > - iounmap(mbox->mbox.hwbase);
> > + iounmap((void __iomem *)mbox->mbox.hwbase);
> >
> > otx2_mbox_destroy(&mbox->mbox);
> > }
> > @@ -1312,7 +1311,7 @@ static irqreturn_t otx2_q_intr_handler(int irq,
> > void *data)
> >
> > /* CQ */
> > for (qidx = 0; qidx < pf->qset.cq_cnt; qidx++) {
> > - ptr = otx2_get_regaddr(pf, NIX_LF_CQ_OP_INT);
> > + ptr = (__force u64 *)otx2_get_regaddr(pf,
> NIX_LF_CQ_OP_INT);
> > val = otx2_atomic64_add((qidx << 44), ptr);
> >
> > otx2_write64(pf, NIX_LF_CQ_OP_INT, (qidx << 44) | @@ -
> 1351,7
> > +1350,7 @@ static irqreturn_t otx2_q_intr_handler(int irq, void *data)
> > * these are fatal errors.
> > */
> >
> > - ptr = otx2_get_regaddr(pf, NIX_LF_SQ_OP_INT);
> > + ptr = (__force u64 *)otx2_get_regaddr(pf,
> NIX_LF_SQ_OP_INT);
> > val = otx2_atomic64_add((qidx << 44), ptr);
> > otx2_write64(pf, NIX_LF_SQ_OP_INT, (qidx << 44) |
> > (val & NIX_SQINT_BITS));
>
> All the changes here looks unrelated. I guess they fix compile warnings.
> Should go into a separate patch, earlier in the series.
Ack, will submit v11 with updates or post separately.
>
> /P
Powered by blists - more mailing lists