netdev - Re: [PATCH net-next v5 07/14] xsc: Init auxiliary device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5fd46c35-8aca-4242-8128-67ca4f41eb3c@yunsilicon.com>
Date: Wed, 26 Feb 2025 17:39:27 +0800
From: "Xin Tian" <tianx@...silicon.com>
To: "Jakub Kicinski" <kuba@...nel.org>
Cc: <netdev@...r.kernel.org>, <leon@...nel.org>, <andrew+netdev@...n.ch>, 
	<pabeni@...hat.com>, <edumazet@...gle.com>, <davem@...emloft.net>, 
	<jeff.johnson@....qualcomm.com>, <przemyslaw.kitszel@...el.com>, 
	<weihg@...silicon.com>, <wanry@...silicon.com>, <horms@...nel.org>, 
	<parthiban.veerasooran@...rochip.com>, <masahiroy@...nel.org>
Subject: Re: [PATCH net-next v5 07/14] xsc: Init auxiliary device

On 2025/2/26 9:12, Jakub Kicinski wrote:
> On Tue, 25 Feb 2025 01:24:31 +0800 Xin Tian wrote:
>> Our device supports both Ethernet and RDMA functionalities, and
>> leveraging the auxiliary bus perfectly addresses our needs for
>> managing these distinct features. This patch utilizes auxiliary
>> device to handle the Ethernet functionality, while defining
>> xsc_adev_list to reserve expansion space for future RDMA
>> capabilities.
> drivers/net/ethernet/yunsilicon/xsc/pci/adev.c:90:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
>     90 |         if (adev_id < 0)
>        |             ^~~~~~~~~~~
> drivers/net/ethernet/yunsilicon/xsc/pci/adev.c:104:9: note: uninitialized use occurs here
>    104 |         return ret;
>        |                ^~~
> drivers/net/ethernet/yunsilicon/xsc/pci/adev.c:90:2: note: remove the 'if' if its condition is always false
>     90 |         if (adev_id < 0)
>        |         ^~~~~~~~~~~~~~~~
>     91 |                 goto err_free_adev_list;
>        |                 ~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/yunsilicon/xsc/pci/adev.c:82:9: note: initialize the variable 'ret' to silence this warning
>     82 |         int ret;
>        |                ^
>        |                 = 0
My bad, will fix.