netdev - Re: [PATCH v1 net-next 07/12] ipv4: fib: Add fib_info_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL030b0asmFu7VmqENG8nqcLAN6=sSaXLTzVq8g6KtH=Q@mail.gmail.com>
Date: Wed, 26 Feb 2025 12:18:17 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 07/12] ipv4: fib: Add fib_info_hash_grow().

On Tue, Feb 25, 2025 at 7:26 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> When the number of struct fib_info exceeds the hash table size in
> fib_create_info(), we try to allocate a new hash table with the
> doubled size.
>
> The allocation is done in fib_create_info(), and if successful, each
> struct fib_info is moved to the new hash table by fib_info_hash_move().
>
> Let's integrate the allocation and fib_info_hash_move() as
> fib_info_hash_grow() to make the following change cleaner.
>
> While at it, fib_info_hash_grow() is placed near other hash-table-specific
> functions.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>