netdev - Re: [PATCH net-next] net: enetc: Support ethernet aliases in dts.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250226151010.u2jj5n6e3ofbed6p@skbuf>
Date: Wed, 26 Feb 2025 17:10:10 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Shenwei Wang <shenwei.wang@....com>
Cc: Andrew Lunn <andrew@...n.ch>, Claudiu Manoil <claudiu.manoil@....com>,
	Wei Fang <wei.fang@....com>, Clark Wang <xiaoning.wang@....com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH net-next] net: enetc: Support ethernet aliases in dts.

On Wed, Feb 26, 2025 at 05:07:15PM +0200, Shenwei Wang wrote:
> > -----Original Message-----
> > From: Andrew Lunn <andrew@...n.ch>
> > Sent: Wednesday, February 26, 2025 8:58 AM
> > To: Shenwei Wang <shenwei.wang@....com>
> > Cc: Claudiu Manoil <claudiu.manoil@....com>; Vladimir Oltean
> > <vladimir.oltean@....com>; Wei Fang <wei.fang@....com>; Clark Wang
> > <xiaoning.wang@....com>; Andrew Lunn <andrew+netdev@...n.ch>; David S.
> > Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> > Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>;
> > imx@...ts.linux.dev; netdev@...r.kernel.org; dl-linux-imx <linux-imx@....com>
> > Subject: [EXT] Re: [PATCH net-next] net: enetc: Support ethernet aliases in dts.
> > On Tue, Feb 25, 2025 at 03:44:58PM -0600, Shenwei Wang wrote:
> > > Retrieve the "ethernet" alias ID from the DTS and assign it as the
> > > interface name (e.g., "eth0", "eth1"). This ensures predictable naming
> > > aligned with the DTS's configuration.
> > >
> > > If no alias is defined, fall back to the kernel's default enumeration
> > > to maintain backward compatibility.
> > 
> > GregKH and others will tell you this is a user space problem. Ethernet names have
> > never been stable, user space has always had to deal with this problem. Please
> > use a udev rule, systemd naming, etc.
> 
> Thanks Andrew.
> Does it mean the ethernet aliases defined in the dts are no longer recommended or supported?
> 
> Thanks,
> Shenwei

Aliases are recommended at least for U-Boot fixups of any kind (MAC
addresses, but not necessarily). You never want to perform a fixup based
on a hardcoded node path.