netdev - Re: [PATCH *-next 14/18] PM: wakeup: Remove needless return in three void APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i-_08mhOpsecuU+XzS8rKbk9mtgr_Kwx-QGRPh9jumKw@mail.gmail.com>
Date: Wed, 26 Feb 2025 18:06:26 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Zijun Hu <quic_zijuhu@...cinc.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Will Deacon <will@...nel.org>, 
	"Aneesh Kumar K.V" <aneesh.kumar@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>, 
	Nick Piggin <npiggin@...il.com>, Peter Zijlstra <peterz@...radead.org>, Arnd Bergmann <arnd@...db.de>, 
	Thomas Gleixner <tglx@...utronix.de>, Herbert Xu <herbert@...dor.apana.org.au>, 
	"David S. Miller" <davem@...emloft.net>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Danilo Krummrich <dakr@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Johannes Berg <johannes@...solutions.net>, Jamal Hadi Salim <jhs@...atatu.com>, 
	Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, 
	Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Lee Jones <lee@...nel.org>, Thomas Graf <tgraf@...g.ch>, 
	Christoph Hellwig <hch@....de>, Marek Szyprowski <m.szyprowski@...sung.com>, 
	Robin Murphy <robin.murphy@....com>, Miquel Raynal <miquel.raynal@...tlin.com>, 
	Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>, Zijun Hu <zijun_hu@...oud.com>, 
	linux-arch@...r.kernel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
	linux-crypto@...r.kernel.org, netdev@...r.kernel.org, 
	linux-wireless@...r.kernel.org, linux-rdma@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-pm@...r.kernel.org, iommu@...ts.linux.dev, 
	linux-mtd@...ts.infradead.org
Subject: Re: [PATCH *-next 14/18] PM: wakeup: Remove needless return in three
 void APIs

On Fri, Feb 21, 2025 at 2:03 PM Zijun Hu <quic_zijuhu@...cinc.com> wrote:
>
> Remove needless 'return' in the following void APIs:
>
>  __pm_wakeup_event()
>  pm_wakeup_event()
>  pm_wakeup_hard_event()
>
> Since both the API and callee involved are void functions.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> ---
>  include/linux/pm_wakeup.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/pm_wakeup.h b/include/linux/pm_wakeup.h
> index d501c09c60cd..51e0e8dd5f9e 100644
> --- a/include/linux/pm_wakeup.h
> +++ b/include/linux/pm_wakeup.h
> @@ -205,17 +205,17 @@ static inline void device_set_awake_path(struct device *dev)
>
>  static inline void __pm_wakeup_event(struct wakeup_source *ws, unsigned int msec)
>  {
> -       return pm_wakeup_ws_event(ws, msec, false);
> +       pm_wakeup_ws_event(ws, msec, false);
>  }
>
>  static inline void pm_wakeup_event(struct device *dev, unsigned int msec)
>  {
> -       return pm_wakeup_dev_event(dev, msec, false);
> +       pm_wakeup_dev_event(dev, msec, false);
>  }
>
>  static inline void pm_wakeup_hard_event(struct device *dev)
>  {
> -       return pm_wakeup_dev_event(dev, 0, true);
> +       pm_wakeup_dev_event(dev, 0, true);
>  }
>
>  /**
>
> --

Applied as 6.15 material, thanks!