netdev - Re: [PATCH v1 net-next 03/12] ipv4: fib: Allocate fib_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJ5c+Dq6WLb6DDxD=eEkueS_awg6CcFGcTBrpJPBNgrsw@mail.gmail.com>
Date: Wed, 26 Feb 2025 19:09:56 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: David Ahern <dsahern@...nel.org>
Cc: Kuniyuki Iwashima <kuniyu@...zon.com>, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 03/12] ipv4: fib: Allocate fib_info_hash[]
 during netns initialisation.

On Wed, Feb 26, 2025 at 6:48 PM David Ahern <dsahern@...nel.org> wrote:
>
> On 2/25/25 11:22 AM, Kuniyuki Iwashima wrote:
> > diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
> > index 6730e2034cf8..dbf84c23ca09 100644
> > --- a/net/ipv4/fib_frontend.c
> > +++ b/net/ipv4/fib_frontend.c
> > @@ -1615,9 +1615,15 @@ static int __net_init fib_net_init(struct net *net)
> >       error = ip_fib_net_init(net);
> >       if (error < 0)
> >               goto out;
> > +
> > +     error = fib4_semantics_init(net);
> > +     if (error)
> > +             goto out_semantics;
> > +
> >       error = nl_fib_lookup_init(net);
> >       if (error < 0)
> >               goto out_nlfl;
> > +
> >       error = fib_proc_init(net);
> >       if (error < 0)
> >               goto out_proc;
> > @@ -1627,6 +1633,8 @@ static int __net_init fib_net_init(struct net *net)
> >  out_proc:
> >       nl_fib_lookup_exit(net);
> >  out_nlfl:
> > +     fib4_semantics_init(net);
>
> _exit?

Yes, this was mentioned yesterday.