netdev - Re: [PATCH net-next v7 04/12] net: hold netdev instance lock during rtnetlink operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250225190005.2850c2da@kernel.org>
Date: Tue, 25 Feb 2025 19:00:05 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, Saeed Mahameed <saeed@...nel.org>
Subject: Re: [PATCH net-next v7 04/12] net: hold netdev instance lock during
 rtnetlink operations

On Mon, 24 Feb 2025 10:08:00 -0800 Stanislav Fomichev wrote:
> +static inline int netdev_lock_cmp_fn(const struct lockdep_map *a,
> +				     const struct lockdep_map *b)
> +{
> +	/* Only lower devices currently grab the instance lock, so no
> +	 * real ordering issues can occur. In the near future, only
> +	 * hardware devices will grab instance lock which also does not
> +	 * involve any ordering. Suppress lockdep ordering warnings
> +	 * until (if) we start grabbing instance lock on pure SW
> +	 * devices (bond/team/veth/etc).
> +	 */
> +	return -1;

Does this no kill all lockdep warnings?
We still want AA splats for ease of debug, and lockdep warnings
involving other locks.