netdev - Re: [PATCH v1 net-next 03/12] ipv4: fib: Allocate fib_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250226182019.98268-1-kuniyu@amazon.com>
Date: Wed, 26 Feb 2025 10:20:19 -0800
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <dsahern@...nel.org>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <horms@...nel.org>,
	<kuba@...nel.org>, <kuni1840@...il.com>, <kuniyu@...zon.com>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH v1 net-next 03/12] ipv4: fib: Allocate fib_info_hash[] during netns initialisation.

From: David Ahern <dsahern@...nel.org>
Date: Wed, 26 Feb 2025 11:12:13 -0700
> On 2/26/25 11:09 AM, Eric Dumazet wrote:
> >>> @@ -1627,6 +1633,8 @@ static int __net_init fib_net_init(struct net *net)
> >>>  out_proc:
> >>>       nl_fib_lookup_exit(net);
> >>>  out_nlfl:
> >>> +     fib4_semantics_init(net);
> >>
> >> _exit?
> > 
> > Yes, this was mentioned yesterday.
> 
> not in this code path but rather fib_net_exit. Hence me pointing out
> this one only

Sorry, actually I realised the path and fixed just after sending the
diff yesterday.

Will send v2 shortly.

Thank you both for the review !