| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20250226074837.1679988-1-yong.liang.choong@linux.intel.com>
Date: Wed, 26 Feb 2025 15:48:31 +0800
From: Choong Yong Liang <yong.liang.choong@...ux.intel.com>
To: Simon Horman <horms@...nel.org>,
Jose Abreu <joabreu@...opsys.com>,
Jose Abreu <Jose.Abreu@...opsys.com>,
David E Box <david.e.box@...ux.intel.com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>,
"H . Peter Anvin" <hpa@...or.com>,
Rajneesh Bhardwaj <irenic.rajneesh@...il.com>,
David E Box <david.e.box@...el.com>,
Andrew Lunn <andrew+netdev@...n.ch>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jiawen Wu <jiawenwu@...stnetic.com>,
Mengyuan Lou <mengyuanlou@...-swift.com>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
Hans de Goede <hdegoede@...hat.com>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
Richard Cochran <richardcochran@...il.com>,
Serge Semin <fancer.lancer@...il.com>
Cc: x86@...nel.org,
linux-kernel@...r.kernel.org,
netdev@...r.kernel.org,
platform-driver-x86@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org
Subject: [PATCH net-next v8 0/6] Enable SGMII and 2500BASEX interface mode switching for Intel platforms
During the interface mode change, the 'phylink_major_config' function will
be triggered in phylink. The modification of the following functions will
support the switching between SGMII and 2500BASE-X interface modes for
the Intel platform:
- xpcs_switch_interface_mode: Re-initiates clause 37 auto-negotiation for
the SGMII interface mode to perform auto-negotiation.
- mac_finish: Configures the SerDes according to the interface mode.
With the above changes, the code will work as follows during the interface
mode change. The PCS will reconfigure according to the pcs_neg_mode and the
selected interface mode. Then, the MAC driver will perform SerDes
configuration in 'mac_finish' based on the selected interface mode. During
the SerDes configuration, the selected interface mode will identify TSN
lane registers from FIA and then send IPC commands to the Power Management
Controller (PMC) through the PMC driver/API. The PMC will act as a proxy to
program the PLL registers.
Change log:
v1 -> v2:
- Add static to pmc_lpm_modes declaration
- Add cur_link_an_mode to the kernel doc
- Combine 2 commits i.e. "stmmac: intel: Separate driver_data of ADL-N
from TGL" and "net: stmmac: Add 1G/2.5G auto-negotiation
support for ADL-N" into 1 commit.
v2 -> v3:
- Create `pmc_ipc.c` file for `intel_pmc_ipc()` function and
allocate the file in `arch/x86/platform/intel/` directory.
- Update phylink's AN mode during phy interface change and
not exposing phylink's AN mode into phylib.
v3 -> v4:
- Introduce `allow_switch_interface` flag to have all ethtool
link modes that are supported and advertised will be published.
- Introduce `mac_get_pcs_neg_mode` function that selects the PCS
negotiation mode according to the interface mode.
- Remove pcs-xpcs.c changes and handle pcs during `mac_select_pcs`
function
- Configure SerDes base on the interface on `mac_finish` function.
v4 -> v5:
- remove 'allow_switch_interface' related patches.
- remove 'mac_select_pcs' related patches.
- add a soft reset according to XPCS datasheet for re-initiate Clause 37
auto-negotiation when switching to SGMII interface mode.
v5 -> v6:
- Remove 'mac_get_pcs_neg_mode' related patches.
The pcs_neg_mode is properly handled by the
'net: add negotiation of in-band capabilities' patch series:
https://patchwork.kernel.org/project/netdevbpf/cover/Z08kCwxdkU4n2V6x@shell.armlinux.org.uk/
- Using act_link_an_mode to determine PHY, as cfg_link_an_mode was not
updated for the 2500BASE-X interface mode, caused a failure to link up.
- Clean up and standardize the interface mode switch for xpcs.
v6 -> v7:
- Remove the "net: phylink: use act_link_an_mode to determine PHY" patch.
- Use pl->link_interface in phylink_expects_phy().
- Remove priv->plat->serdes_powerup in intel_tsn_lane_is_available() as it is
always true.
- Refactor the code in intel_config_serdes().
- Rename intel_config_serdes() to intel_mac_finish() with an AN mode parameter.
- Define the magic number as "max_fia_regs".
- Store the pointer and the number of elements in the platform info structure.
- Move the arrays to the C file.
v7 -> v8:
- Move xpcs_switch_interface_mode() into xpcs_pre_config().
- Move the "stmmac: intel: interface switching support for EHL platform" commit
into "stmmac: intel: configure SerDes according to the interface mode" to
resolve the "defined but not used" error.
- Changes for the "arch: x86: add IPC mailbox accessor function and add SoC register access" commit:
- Rephrase the second bullet in the patch description.
- Remove 'config INTEL_PMC_IPC' from Kconfig, as discussed.
- Remove the authors from intel_pmc_ipc.h.
- Define VALID_IPC_RESPONSE for package.count.
- Update the copyright year to 2025.
- Create struct pmc_ipc_rbuf.
- Update the function description for intel_pmc_ipc().
v1: https://patchwork.kernel.org/project/netdevbpf/cover/20230622041905.629430-1-yong.liang.choong@linux.intel.com/
v2: https://patchwork.kernel.org/project/netdevbpf/cover/20230804084527.2082302-1-yong.liang.choong@linux.intel.com/
v3: https://patchwork.kernel.org/project/netdevbpf/cover/20230921121946.3025771-1-yong.liang.choong@linux.intel.com/
v4: https://patchwork.kernel.org/project/netdevbpf/cover/20240129130253.1400707-1-yong.liang.choong@linux.intel.com/
v5: https://patchwork.kernel.org/project/netdevbpf/cover/20240215030500.3067426-1-yong.liang.choong@linux.intel.com/
v6: https://patchwork.kernel.org/project/netdevbpf/cover/20250204061020.1199124-1-yong.liang.choong@linux.intel.com/
v7: https://patchwork.kernel.org/project/netdevbpf/cover/20250206131859.2960543-1-yong.liang.choong@linux.intel.com/
Choong Yong Liang (5):
net: phylink: use pl->link_interface in phylink_expects_phy()
net: pcs: xpcs: re-initiate clause 37 Auto-negotiation
stmmac: intel: configure SerDes according to the interface mode
net: stmmac: configure SerDes on mac_finish
stmmac: intel: interface switching support for ADL-N platform
David E. Box (1):
arch: x86: add IPC mailbox accessor function and add SoC register
access
MAINTAINERS | 1 +
drivers/net/ethernet/stmicro/stmmac/Kconfig | 1 +
.../net/ethernet/stmicro/stmmac/dwmac-intel.c | 231 +++++++++++++++++-
.../net/ethernet/stmicro/stmmac/dwmac-intel.h | 29 +++
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 13 +
drivers/net/pcs/pcs-xpcs-wx.c | 4 +-
drivers/net/pcs/pcs-xpcs.c | 29 ++-
drivers/net/phy/phylink.c | 2 +-
.../linux/platform_data/x86/intel_pmc_ipc.h | 94 +++++++
include/linux/stmmac.h | 4 +
10 files changed, 394 insertions(+), 14 deletions(-)
create mode 100644 include/linux/platform_data/x86/intel_pmc_ipc.h
--
2.34.1
Powered by blists - more mailing lists