netdev - Re: [PATCH net] gve: unlink old napi when stopping a queue using queue API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ff78832-006d-47da-8e27-12c70ac82a8f@intel.com>
Date: Wed, 26 Feb 2025 16:44:01 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Harshitha Ramamurthy <hramamurthy@...gle.com>, <netdev@...r.kernel.org>
CC: <jeroendb@...gle.com>, <andrew+netdev@...n.ch>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<pkaligineedi@...gle.com>, <shailend@...gle.com>, <willemb@...gle.com>,
	<linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH net] gve: unlink old napi when stopping a queue using
 queue API



On 2/25/2025 4:35 PM, Harshitha Ramamurthy wrote:
> When a queue is stopped using the ndo queue API, before
> destroying its page pool, the associated NAPI instance
> needs to be unlinked to avoid warnings.
> 
> Handle this by calling page_pool_disable_direct_recycling()
> when stopping a queue.
> 
> Cc: stable@...r.kernel.org
> Fixes: ebdfae0d377b ("gve: adopt page pool for DQ RDA mode")
> Reviewed-by: Praveen Kaligineedi <pkaligineedi@...gle.com>
> Signed-off-by: Harshitha Ramamurthy <hramamurthy@...gle.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  drivers/net/ethernet/google/gve/gve_rx_dqo.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/google/gve/gve_rx_dqo.c b/drivers/net/ethernet/google/gve/gve_rx_dqo.c
> index 8ac0047f1ada..f0674a443567 100644
> --- a/drivers/net/ethernet/google/gve/gve_rx_dqo.c
> +++ b/drivers/net/ethernet/google/gve/gve_rx_dqo.c
> @@ -109,10 +109,12 @@ static void gve_rx_reset_ring_dqo(struct gve_priv *priv, int idx)
>  void gve_rx_stop_ring_dqo(struct gve_priv *priv, int idx)
>  {
>  	int ntfy_idx = gve_rx_idx_to_ntfy(priv, idx);
> +	struct gve_rx_ring *rx = &priv->rx[idx];
>  
>  	if (!gve_rx_was_added_to_block(priv, idx))
>  		return;
>  
> +	page_pool_disable_direct_recycling(rx->dqo.page_pool);
>  	gve_remove_napi(priv, ntfy_idx);
>  	gve_rx_remove_from_block(priv, idx);
>  	gve_rx_reset_ring_dqo(priv, idx);