netdev - Re: [PATCH net-next] net-sysfs: remove unused initial ret values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b35544a-8666-4828-8871-8cd38b189417@intel.com>
Date: Thu, 27 Feb 2025 10:33:33 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: Antoine Tenart <atenart@...nel.org>, <davem@...emloft.net>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>
CC: <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net-sysfs: remove unused initial ret values



On 2/26/2025 6:46 PM, Antoine Tenart wrote:
> In some net-sysfs functions the ret value is initialized but never used
> as it is always overridden. Remove those.
> 
> Signed-off-by: Antoine Tenart <atenart@...nel.org>
> ---
>   net/core/net-sysfs.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index f61c1d829811..8d9dc048a548 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c
> @@ -568,7 +568,7 @@ static ssize_t ifalias_store(struct device *dev, struct device_attribute *attr,
>   	struct net_device *netdev = to_net_dev(dev);
>   	struct net *net = dev_net(netdev);
>   	size_t count = len;
> -	ssize_t ret = 0;
> +	ssize_t ret;
>   
>   	if (!ns_capable(net->user_ns, CAP_NET_ADMIN))
>   		return -EPERM;
> @@ -597,7 +597,7 @@ static ssize_t ifalias_show(struct device *dev,
>   {
>   	const struct net_device *netdev = to_net_dev(dev);
>   	char tmp[IFALIASZ];
> -	ssize_t ret = 0;
> +	ssize_t ret;
>   
>   	ret = dev_get_alias(netdev, tmp, sizeof(tmp));
>   	if (ret > 0)
> @@ -638,7 +638,7 @@ static ssize_t phys_port_id_show(struct device *dev,
>   {
>   	struct net_device *netdev = to_net_dev(dev);
>   	struct netdev_phys_item_id ppid;
> -	ssize_t ret = -EINVAL;
> +	ssize_t ret;
>   
>   	/* The check is also done in dev_get_phys_port_id; this helps returning
>   	 * early without hitting the locking section below.
> @@ -664,8 +664,8 @@ static ssize_t phys_port_name_show(struct device *dev,
>   				   struct device_attribute *attr, char *buf)
>   {
>   	struct net_device *netdev = to_net_dev(dev);
> -	ssize_t ret = -EINVAL;
>   	char name[IFNAMSIZ];
> +	ssize_t ret;
>   
>   	/* The checks are also done in dev_get_phys_port_name; this helps
>   	 * returning early without hitting the locking section below.
> @@ -693,7 +693,7 @@ static ssize_t phys_switch_id_show(struct device *dev,
>   {
>   	struct net_device *netdev = to_net_dev(dev);
>   	struct netdev_phys_item_id ppid = { };
> -	ssize_t ret = -EINVAL;
> +	ssize_t ret;
>   
>   	/* The checks are also done in dev_get_phys_port_name; this helps
>   	 * returning early without hitting the locking section below. This works
Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>