netdev - Re: [PATCH net-next] net: ethernet: ti: cpsw_new: populate netdev of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c7df96fdde9cef6292ad9ff7c12f863a350878b.camel@siemens.com>
Date: Thu, 27 Feb 2025 14:18:20 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "andrew@...n.ch" <andrew@...n.ch>
CC: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "s-vadapalli@...com"
	<s-vadapalli@...com>, "davem@...emloft.net" <davem@...emloft.net>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kuba@...nel.org" <kuba@...nel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"rogerq@...nel.org" <rogerq@...nel.org>, "pabeni@...hat.com"
	<pabeni@...hat.com>
Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw_new: populate netdev
 of_node

Hi Andrew,

On Thu, 2025-02-27 at 14:24 +0100, Andrew Lunn wrote:
> On Thu, Feb 27, 2025 at 08:46:46AM +0100, A. Sverdlin wrote:
> > From: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> > 
> > So that of_find_net_device_by_node() can find cpsw-nuss ports and other DSA
                                                      ^^^^^

Oops, copy-paste failure here, nuss was for the am65-cpsw-nuss driver,
maybe "-nuss" could be simply deleted from the commit message on "apply"...

> > switches can be stacked downstream. Tested in conjunction with KSZ8873.
> > 
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> 
> Consistent with other TI drivers. But it looks like only TI drivers
> need this, which suggests they are all doing something wrong, maybe
> for legacy reasons.

Well, yes, they re-invent the wheel, mimicking the DSA infrastructure
without using it. CPSW is a switch, as the name suggests, but the
effort has not been spent to bring it to DSA home ;-)

So what happens here actually is, I'm assigning a DT node to "user port"
in DSA terms, and dsa_register_switch() would for sure do it...

> Reviewed-by: Andrew Lunn <andrew@...n.ch>

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com