| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202502280225.eNUtFj7i-lkp@intel.com>
Date: Fri, 28 Feb 2025 02:24:13 +0800
From: kernel test robot <lkp@...el.com>
To: Gerhard Engleder <gerhard@...leder-embedded.com>, andrew@...n.ch,
hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
Gerhard Engleder <gerhard@...leder-embedded.com>
Subject: Re: [PATCH net-next v8 8/8] tsnep: Add loopback selftests
Hi Gerhard,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Gerhard-Engleder/net-phy-Allow-loopback-speed-selection-for-PHY-drivers/20250225-103125
base: net-next/main
patch link: https://lore.kernel.org/r/20250224211531.115980-9-gerhard%40engleder-embedded.com
patch subject: [PATCH net-next v8 8/8] tsnep: Add loopback selftests
config: mips-randconfig-r064-20250227 (https://download.01.org/0day-ci/archive/20250228/202502280225.eNUtFj7i-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 204dcafec0ecf0db81d420d2de57b02ada6b09ec)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250228/202502280225.eNUtFj7i-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502280225.eNUtFj7i-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/net/ethernet/engleder/tsnep_selftests.c:7:
include/net/selftests.h:50:59: error: 'void' must be the first and only parameter if specified
50 | static inline int net_selftest_set_get_count(int set, void)
| ^
include/net/selftests.h:50:59: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
>> drivers/net/ethernet/engleder/tsnep_selftests.c:762:65: error: too few arguments to function call, expected 2, have 1
762 | count += net_selftest_set_get_count(NET_SELFTEST_LOOPBACK_SPEED);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
include/net/selftests.h:50:19: note: 'net_selftest_set_get_count' declared here
50 | static inline int net_selftest_set_get_count(int set, void)
| ^ ~~~~~~~~~~~~~
drivers/net/ethernet/engleder/tsnep_selftests.c:763:65: error: too few arguments to function call, expected 2, have 1
763 | count += net_selftest_set_get_count(NET_SELFTEST_LOOPBACK_SPEED);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
include/net/selftests.h:50:19: note: 'net_selftest_set_get_count' declared here
50 | static inline int net_selftest_set_get_count(int set, void)
| ^ ~~~~~~~~~~~~~
>> drivers/net/ethernet/engleder/tsnep_selftests.c:773:65: error: incompatible pointer types passing 'u8 **' (aka 'unsigned char **') to parameter of type 'u8 *' (aka 'unsigned char *'); remove & [-Werror,-Wincompatible-pointer-types]
773 | net_selftest_set_get_strings(NET_SELFTEST_LOOPBACK_SPEED, 100, &data);
| ^~~~~
include/net/selftests.h:55:73: note: passing argument to parameter 'data' here
55 | static inline void net_selftest_set_get_strings(int set, int speed, u8 *data)
| ^
drivers/net/ethernet/engleder/tsnep_selftests.c:774:66: error: incompatible pointer types passing 'u8 **' (aka 'unsigned char **') to parameter of type 'u8 *' (aka 'unsigned char *'); remove & [-Werror,-Wincompatible-pointer-types]
774 | net_selftest_set_get_strings(NET_SELFTEST_LOOPBACK_SPEED, 1000, &data);
| ^~~~~
include/net/selftests.h:55:73: note: passing argument to parameter 'data' here
55 | static inline void net_selftest_set_get_strings(int set, int speed, u8 *data)
| ^
drivers/net/ethernet/engleder/tsnep_selftests.c:825:64: error: too few arguments to function call, expected 2, have 1
825 | data += net_selftest_set_get_count(NET_SELFTEST_LOOPBACK_SPEED);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
include/net/selftests.h:50:19: note: 'net_selftest_set_get_count' declared here
50 | static inline int net_selftest_set_get_count(int set, void)
| ^ ~~~~~~~~~~~~~
1 warning and 6 errors generated.
vim +762 drivers/net/ethernet/engleder/tsnep_selftests.c
757
758 int tsnep_ethtool_get_test_count(void)
759 {
760 int count = TSNEP_TEST_COUNT;
761
> 762 count += net_selftest_set_get_count(NET_SELFTEST_LOOPBACK_SPEED);
763 count += net_selftest_set_get_count(NET_SELFTEST_LOOPBACK_SPEED);
764
765 return count;
766 }
767
768 void tsnep_ethtool_get_test_strings(u8 *data)
769 {
770 memcpy(data, tsnep_test_strings, sizeof(tsnep_test_strings));
771 data += sizeof(tsnep_test_strings);
772
> 773 net_selftest_set_get_strings(NET_SELFTEST_LOOPBACK_SPEED, 100, &data);
774 net_selftest_set_get_strings(NET_SELFTEST_LOOPBACK_SPEED, 1000, &data);
775 }
776
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists