netdev - Re: [PATCH v2 net-next 00/12] ipv4: fib: Convert RTM_NEWROUTE and RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f7da7c8-e3da-4dfc-bc43-3cd525e333a8@kernel.org>
Date: Thu, 27 Feb 2025 16:58:06 -0700
From: David Ahern <dsahern@...nel.org>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>
Cc: Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 00/12] ipv4: fib: Convert RTM_NEWROUTE and
 RTM_DELROUTE to per-netns RTNL.

On 2/26/25 12:25 PM, Kuniyuki Iwashima wrote:
> Patch 1 is misc cleanup.
> Patch 2 ~ 8 converts two fib_info hash tables to per-netns.
> Patch 9 ~ 12 converts rtnl_lock() to rtnl_net_lcok().
> 
> 
> Changes:
>   v2:
>     * Add Eric's tags except for patch 3 (due to a minor change for exit_batch())
>     * Patch 3
>       * Fix memleak by calling fib4_semantics_exit() properly
>       * Move fib4_semantics_exit() to fib_net_exit_batch()
> 
>   v1: https://lore.kernel.org/netdev/20250225182250.74650-1-kuniyu@amazon.com/
> 
> 
> Kuniyuki Iwashima (12):
>   ipv4: fib: Use cached net in fib_inetaddr_event().
>   ipv4: fib: Allocate fib_info_hash[] and fib_info_laddrhash[] by
>     kvmalloc_array().
>   ipv4: fib: Allocate fib_info_hash[] during netns initialisation.
>   ipv4: fib: Make fib_info_hashfn() return struct hlist_head.
>   ipv4: fib: Remove fib_info_laddrhash pointer.
>   ipv4: fib: Remove fib_info_hash_size.
>   ipv4: fib: Add fib_info_hash_grow().
>   ipv4: fib: Namespacify fib_info hash tables.
>   ipv4: fib: Hold rtnl_net_lock() for ip_fib_net_exit().
>   ipv4: fib: Hold rtnl_net_lock() in ip_rt_ioctl().
>   ipv4: fib: Move fib_valid_key_len() to rtm_to_fib_config().
>   ipv4: fib: Convert RTM_NEWROUTE and RTM_DELROUTE to per-netns RTNL.
> 
>  include/net/ip_fib.h     |   2 +
>  include/net/netns/ipv4.h |   3 +
>  net/ipv4/fib_frontend.c  |  74 ++++++++++----
>  net/ipv4/fib_semantics.c | 207 +++++++++++++++++++--------------------
>  net/ipv4/fib_trie.c      |  22 -----
>  5 files changed, 160 insertions(+), 148 deletions(-)
> 

For the set:
Reviewed-by: David Ahern <dsahern@...nel.org>