netdev - Re: [PATCH net-next v9 03/12] net: hold netdev instance lock during queue operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iLpknvoU+XKRB77qrbXrZv_XOSjvbYUZVbSAwHtTotVDQ@mail.gmail.com>
Date: Fri, 28 Feb 2025 09:48:18 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, 
	pabeni@...hat.com, Saeed Mahameed <saeed@...nel.org>
Subject: Re: [PATCH net-next v9 03/12] net: hold netdev instance lock during
 queue operations

On Fri, Feb 28, 2025 at 5:53 AM Stanislav Fomichev <sdf@...ichev.me> wrote:
>
> For the drivers that use queue management API, switch to the mode where
> core stack holds the netdev instance lock. This affects the following
> drivers:
> - bnxt
> - gve
> - netdevsim
>
> Originally I locked only start/stop, but switched to holding the
> lock over all iterations to make them look atomic to the device
> (feels like it should be easier to reason about).
>
> Cc: Saeed Mahameed <saeed@...nel.org>
> Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>