netdev - Re: [PATCH net-next v6 00/14] xsc: ADD Yunsilicon XSC Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <f9b85c0e-b9eb-4676-9c09-8617220115d6@yunsilicon.com>
Date: Fri, 28 Feb 2025 21:43:19 +0800
From: "Xin Tian" <tianx@...silicon.com>
To: "Jakub Kicinski" <kuba@...nel.org>
Cc: <netdev@...r.kernel.org>, <leon@...nel.org>, <andrew+netdev@...n.ch>, 
	<pabeni@...hat.com>, <edumazet@...gle.com>, <davem@...emloft.net>, 
	<jeff.johnson@....qualcomm.com>, <przemyslaw.kitszel@...el.com>, 
	<weihg@...silicon.com>, <wanry@...silicon.com>, <horms@...nel.org>, 
	<parthiban.veerasooran@...rochip.com>, <masahiroy@...nel.org>
Subject: Re: [PATCH net-next v6 00/14] xsc: ADD Yunsilicon XSC Ethernet Driver

On 2025/2/28 0:23, Jakub Kicinski wrote:
> On Thu, 27 Feb 2025 16:26:36 +0800 Xin Tian wrote:
>> The patch series adds the xsc driver, which will support the YunSilicon
>> MS/MC/MV series of network cards. These network cards offer support for
>> high-speed Ethernet and RDMA networking, with speeds of up to 200Gbps.
>>
>> The Ethernet functionality is implemented by two modules. One is a
>> PCI driver(xsc_pci), which provides PCIe configuration,
>> CMDQ service (communication with firmware), interrupt handling,
>> hardware resource management, and other services, while offering
>> common interfaces for Ethernet and future InfiniBand drivers to
>> utilize hardware resources. The other is an Ethernet driver(xsc_eth),
>> which handles Ethernet interface configuration and data
>> transmission/reception.
>>
>> - Patches 1-7 implement the PCI driver
>> - Patches 8-14 implement the Ethernet driver
>>
>> This submission is the first phase, which includes the PF-based Ethernet
>> transmit and receive functionality. Once this is merged, we will submit
>> additional patches to implement support for other features, such as SR-IOV,
>> ethtool support, and a new RDMA driver.
> drivers/net/ethernet/yunsilicon/xsc/pci/cmdq.c:525:14-15: WARNING: *_pool_zalloc should be used for mailbox -> buf, instead of *_pool_alloc/memset
> drivers/net/ethernet/yunsilicon/xsc/pci/hw.c:40:17-24: WARNING: vzalloc should be used for board_info [ i ], instead of vmalloc/memset
> drivers/net/ethernet/yunsilicon/xsc/net/main.c:1946:21-22: WARNING kvmalloc is used to allocate this memory at line 1933
> drivers/net/ethernet/yunsilicon/xsc/net/main.c:1968:22-28: ERROR: adapter is NULL but dereferenced.
> drivers/net/ethernet/yunsilicon/xsc/net/xsc_eth_tx.c:284:14-21: WARNING: Unsigned expression compared with zero: num_dma < 0
Thanks, I'll fix them.