netdev - Re: [GIT PULL] afs, rxrpc: Clean up refcounting on afs_cell and afs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3399367.1740753918@warthog.procyon.org.uk>
Date: Fri, 28 Feb 2025 14:45:18 +0000
From: David Howells <dhowells@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: dhowells@...hat.com, Christian Brauner <brauner@...nel.org>,
    Marc Dionne <marc.dionne@...istor.com>,
    "David S. Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
    linux-afs@...ts.infradead.org, linux-fsdevel@...ts.infradead.org,
    netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] afs, rxrpc: Clean up refcounting on afs_cell and afs_server records

Jakub Kicinski <kuba@...nel.org> wrote:

> fs/afs/cell.c:203:5-22: WARNING: Unsigned expression compared with zero: cell -> dynroot_ino < 0

I'll make this change:

--- a/fs/afs/cell.c
+++ b/fs/afs/cell.c
@@ -200,7 +200,7 @@ static struct afs_cell *afs_alloc_cell(struct afs_net *net,
        atomic_inc(&net->cells_outstanding);
        cell->dynroot_ino = idr_alloc_cyclic(&net->cells_dyn_ino, cell,
                                             2, INT_MAX / 2, GFP_KERNEL);
-       if (cell->dynroot_ino < 0)
+       if ((int)cell->dynroot_ino < 0)
                goto error;
        cell->debug_id = atomic_inc_return(&cell_debug_id);
 

to patch 2 ("afs: Change dynroot to create contents on demand").

I'm not sure why gcc didn't warn about this - I'm sure it used to.

David