netdev - Re: [iwl-net v2 4/5] ice: fix input validation for virtchnl BW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250228171901.GP1615191@kernel.org>
Date: Fri, 28 Feb 2025 17:19:01 +0000
From: Simon Horman <horms@...nel.org>
To: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@...ux.intel.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	Lukasz Czapnik <lukasz.czapnik@...el.com>,
	Jedrzej Jagielski <jedrzej.jagielski@...el.com>
Subject: Re: [iwl-net v2 4/5] ice: fix input validation for virtchnl BW

On Tue, Feb 25, 2025 at 10:08:48AM +0100, Martyna Szapar-Mudlaw wrote:
> From: Lukasz Czapnik <lukasz.czapnik@...el.com>
> 
> Add missing validation of tc and queue id values sent by a VF in
> ice_vc_cfg_q_bw().
> Additionally fixed logged value in the warning message,
> where max_tx_rate was incorrectly referenced instead of min_tx_rate.
> Also correct error handling in this function by properly exiting
> when invalid configuration is detected.
> 
> Fixes: 015307754a19 ("ice: Support VF queue rate limit and quanta size configuration")
> Reviewed-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> Signed-off-by: Lukasz Czapnik <lukasz.czapnik@...el.com>
> Co-developed-by: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@...ux.intel.com>
> Signed-off-by: Martyna Szapar-Mudlaw <martyna.szapar-mudlaw@...ux.intel.com>

Reviewed-by: Simon Horman <horms@...nel.org>