[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0f196026-02ec-4db0-90b0-10c1e720c345@kernel.org>
Date: Sat, 1 Mar 2025 11:52:06 +0100
From: Matthieu Baerts <matttbe@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
andrew+netdev@...n.ch, horms@...nel.org, shuah@...nel.org, petrm@...dia.com,
willemb@...gle.com, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next] selftests: net: report output format as TAP 13
in Python tests
Hi Jakub,
On 28/02/2025 19:00, Jakub Kicinski wrote:
> The Python lib based tests report that they are producing
> "KTAP version 1", but really we aren't making use of any
> KTAP features, like subtests. Our output is plain TAP.
>
> Report TAP 13 instead of KTAP 1, this is what mptcp tests do,
Indeed, and also TC tests, and all the ones using kselftest_harness.h I
think.
> and what NIPA knows how to parse best. For HW testing we need
> precise subtest result tracking.
I guess the best would be to have the kselftests infrastructure fully
supporting KTAP, and then have a way for each test to print subtests
correctly, not nested in the comments like it is done for the moment.
But that looks harder to put in place, and the current solution is used
in a few areas.
Good idea to switch to 'TAP version 13' for the moment, and re-use the
existing parsing in NIPA!
Acked-by: Matthieu Baerts (NGI0) <matttbe@...nel.org>
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
Powered by blists - more mailing lists