netdev - Re: [PATCH net v2] idpf: synchronize pending IRQs after disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250228164711.52f7a54a@kernel.org>
Date: Fri, 28 Feb 2025 16:47:11 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Ahmed Zaki <ahmed.zaki@...el.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
 <pabeni@...hat.com>, <edumazet@...gle.com>, <andrew+netdev@...n.ch>,
 <netdev@...r.kernel.org>, <willemb@...gle.com>, Madhu Chittim
 <madhu.chittim@...el.com>, Simon Horman <horms@...nel.org>, Samuel Salin
 <Samuel.salin@...el.com>
Subject: Re: [PATCH net v2] idpf: synchronize pending IRQs after disable

On Fri, 28 Feb 2025 16:59:47 -0700 Ahmed Zaki wrote:
> Most drivers call synchronize_irq() in the same order as this patch, for ex:
> bnxt_disable_int_sync()
> iavf_irq_disable()
> ice_vsi_dis_irq()
> 
> 
> The order is:
> 1 - disable IRQ registers
> 2 - synchronize_irq()     <-- currently missed in IDPF
> 3 - delete napis
> 4 - free IRQs
> 
> May be "races" is the wrong word, I will try to re-word.

I still have no idea what the problem is.

If you can't explain what the bug is let's just drop this patch :/