netdev - Re: [PATCH bpf-next] bpf: no longer acquire map_idr_lock in bpf_map_inc_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8OgzrmLG0uvrsR_@mini-arch>
Date: Sat, 1 Mar 2025 16:05:34 -0800
From: Stanislav Fomichev <stfomichev@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	John Fastabend <john.fastabend@...il.com>,
	Stanislav Fomichev <sdf@...ichev.me>, netdev@...r.kernel.org,
	bpf@...r.kernel.org, eric.dumazet@...il.com,
	Kui-Feng Lee <kuifeng@...a.com>,
	Martin KaFai Lau <martin.lau@...nel.org>
Subject: Re: [PATCH bpf-next] bpf: no longer acquire map_idr_lock in
 bpf_map_inc_not_zero()

On 03/01, Eric Dumazet wrote:
> bpf_sk_storage_clone() is the only caller of bpf_map_inc_not_zero()
> and is holding rcu_read_lock().
> 
> map_idr_lock does not add any protection, just remove the cost
> for passive TCP flows.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Stanislav Fomichev <sdf@...ichev.me>