netdev - Re: [PATCH net-next v10 04/14] net: hold netdev instance lock during qdisc ndo_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMkj=s+0G7AkCBdgBp5vM3xhusUpuX3D+oQZL+hWPFSJjA@mail.gmail.com>
Date: Sun, 2 Mar 2025 15:56:27 -0500
From: Jamal Hadi Salim <jhs@...atatu.com>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, Cong Wang <xiyou.wangcong@...il.com>, 
	Jiri Pirko <jiri@...nulli.us>, Saeed Mahameed <saeed@...nel.org>
Subject: Re: [PATCH net-next v10 04/14] net: hold netdev instance lock during
 qdisc ndo_setup_tc

On Sat, Mar 1, 2025 at 7:09 PM Stanislav Fomichev <sdf@...ichev.me> wrote:
>
> Qdisc operations that can lead to ndo_setup_tc might need
> to have an instance lock.

Sorry, havent followed this work - "might need" here means that
sometimes it may and sometimes it may not need the device instance
lock (I suppose depending on the driver)?

Since i dont know enough about the motivation for the instance lock, I
just reviewed for consistency and for that:
Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal