[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+V-a8tjOmn4BAamr6BrniTiyMxNYMCRrnZaqzEs_Xr=359Rvg@mail.gmail.com>
Date: Sun, 2 Mar 2025 21:43:47 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: "Russell King (Oracle)" <linux@...linux.org.uk>, Geert Uytterhoeven <geert+renesas@...der.be>,
Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>, Giuseppe Cavallaro <peppe.cavallaro@...com>,
Jose Abreu <joabreu@...opsys.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
Biju Das <biju.das.jz@...renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@...esas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH 2/3] dt-bindings: net: Document GBETH bindings for Renesas
RZ/V2H(P) SoC
On Sun, Mar 2, 2025 at 9:39 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> > > > I can certainly do that, but not sure in the DT we will be describing
> > > > the HW correctly then. I'll have to hide *-180 clocks In the DT and
> > > > handle and turning on/off these clocks in the clock driver.
> > > ...
> > > > clocks = <&cpg CPG_MOD 0xbd>,
> > > > <&cpg CPG_MOD 0xbc>,
> > > > <&cpg CPG_CORE R9A09G057_GBETH_0_CLK_PTP_REF_I>,
> > > > <&cpg CPG_MOD 0xb8>,
> > > > <&cpg CPG_MOD 0xb9>,
> > > > <&cpg CPG_MOD 0xba>,
> > > > <&cpg CPG_MOD 0xbb>;
> > >
> > > Your SoC designer really implemented the 0° and 180° as two separate
> > > independently controllable clocks?
> > >
> > Yes there are separate bits to turn ON/OFF the 0° and 180° clocks.
>
> Do you know what the clock tree actually looks like? I can think of
> two different ways this could be implemented:
>
> ----+----------on/off---
> |
> +----not---on/off---
>
> or
>
> -------on/off-+------------------
> |
> +---not---on/off---
>
> In the first, the clocks are siblings. In the second there is
> parent/child relationship.
>
It's the first case in this SoC.
Cheers,
Prabhakar
Powered by blists - more mailing lists