netdev - RE: [Intel-wired-lan] [PATCH iwl-next v5 11/15] ixgbe: add device flash update via devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH8PR11MB7965906990F3D64C8BE9054BF7C92@PH8PR11MB7965.namprd11.prod.outlook.com>
Date: Mon, 3 Mar 2025 08:20:45 +0000
From: "R, Bharath" <bharath.r@...el.com>
To: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "horms@...nel.org" <horms@...nel.org>,
	"jiri@...dia.com" <jiri@...dia.com>, "Jagielski, Jedrzej"
	<jedrzej.jagielski@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"Mrozowicz, SlawomirX" <slawomirx.mrozowicz@...el.com>, "Kwapulinski, Piotr"
	<piotr.kwapulinski@...el.com>, "Wegrzyn, Stefan" <stefan.wegrzyn@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v5 11/15] ixgbe: add device
 flash update via devlink

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Jedrzej Jagielski
> Sent: Friday, February 21, 2025 5:21 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Nguyen, Anthony L <anthony.l.nguyen@...el.com>;
> netdev@...r.kernel.org; horms@...nel.org; jiri@...dia.com; Jagielski, Jedrzej
> <jedrzej.jagielski@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>;
> Mrozowicz, SlawomirX <slawomirx.mrozowicz@...el.com>; Kwapulinski, Piotr
> <piotr.kwapulinski@...el.com>; Wegrzyn, Stefan <stefan.wegrzyn@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v5 11/15] ixgbe: add device flash
> update via devlink
> 
> Use the pldmfw library to implement device flash update for the Intel ixgbe
> networking device driver specifically for E610 devices.
> This support uses the devlink flash update interface.
> 
> Using the pldmfw library, the provided firmware file will be scanned for the
> three major components, "fw.undi" for the Option ROM, "fw.mgmt" for the
> main NVM module containing the primary device firmware, and "fw.netlist"
> containing the netlist module.
> 
> The flash is separated into two banks, the active bank containing the running
> firmware, and the inactive bank which we use for update. Each module is
> updated in a staged process. First, the inactive bank is erased, preparing the
> device for update. Second, the contents of the component are copied to the
> inactive portion of the flash. After all components are updated, the driver
> signals the device to switch the active bank during the next EMP reset.
> 
> With this implementation, basic flash update for the E610 hardware is
> supported.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Co-developed-by: Slawomir Mrozowicz <slawomirx.mrozowicz@...el.com>
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@...el.com>
> Co-developed-by: Piotr Kwapulinski <piotr.kwapulinski@...el.com>
> Signed-off-by: Piotr Kwapulinski <piotr.kwapulinski@...el.com>
> Co-developed-by: Stefan Wegrzyn <stefan.wegrzyn@...el.com>
> Signed-off-by: Stefan Wegrzyn <stefan.wegrzyn@...el.com>
> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@...el.com>
> ---
> v5: fix caps->nvm_unified_update assignment
> ---
>  Documentation/networking/devlink/ixgbe.rst    |  24 +
>  drivers/net/ethernet/intel/Kconfig            |   1 +
>  drivers/net/ethernet/intel/ixgbe/Makefile     |   2 +-
>  .../ethernet/intel/ixgbe/devlink/devlink.c    |   4 +
>  drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 210 ++++++
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h |  11 +
>  .../ethernet/intel/ixgbe/ixgbe_fw_update.c    | 668 ++++++++++++++++++
>  .../ethernet/intel/ixgbe/ixgbe_fw_update.h    |  12 +
>  .../ethernet/intel/ixgbe/ixgbe_type_e610.h    |  64 ++
>  9 files changed, 995 insertions(+), 1 deletion(-)  create mode 100644
> 

Tested-by: Bharath R <bharath.r@...el.com>