netdev - Re: [RESEND] qed: Move a variable assignment behind a null pointer check in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a191bd33-6c59-45c2-9890-265ec182b39a@stanley.mountain>
Date: Mon, 3 Mar 2025 11:28:29 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Ariel Elior <aelior@...vell.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Manish Chopra <manishc@...vell.com>,
	Paolo Abeni <pabeni@...hat.com>,
	Ram Amrani <Ram.Amrani@...iumnetworks.com>,
	Yuval Mintz <Yuval.Mintz@...iumnetworks.com>, cocci@...ia.fr,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND] qed: Move a variable assignment behind a null pointer
 check in two functions

On Mon, Mar 03, 2025 at 09:22:58AM +0100, Markus Elfring wrote:
> > The assignment:
> >
> > 	p_rx = &p_ll2_conn->rx_queue;
> >
> > does not dereference "p_ll2_conn".  It just does pointer math.  So the
> > original code works fine.
> 
> Is there a need to clarify affected implementation details any more?
> https://wiki.sei.cmu.edu/confluence/display/c/EXP34-C.+Do+not+dereference+null+pointers

This is not a NULL dereference.  It's just pointer math.

regards,
dan carpenter