netdev - Re: [PATCH net-next] net: ethtool: Don't check if RSS context exists in case of context 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a548dd08-48f0-404e-8481-3fa5fb3090a4@nvidia.com>
Date: Tue, 4 Mar 2025 13:09:44 +0200
From: Gal Pressman <gal@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
 Andrew Lunn <andrew@...n.ch>, Simon Horman <horms@...nel.org>,
 Joe Damato <jdamato@...tly.com>, Tariq Toukan <tariqt@...dia.com>,
 ecree.xilinx@...il.com
Subject: Re: [PATCH net-next] net: ethtool: Don't check if RSS context exists
 in case of context 0

On 04/03/2025 0:17, Jakub Kicinski wrote:
> On Sun, 2 Mar 2025 11:55:34 +0200 Gal Pressman wrote:
>>>> I can think of something like redirecting all TCP traffic to context 1,
>>>> and then a specific TCP 5-tuple to the default context.  
>>>
>>> The ordering guarantees of ntuple filters are a bit unclear.
>>> My understanding was that first match terminates the search,
>>> actually, so your example wouldn't work :S  
>>
>> The ordering should be done according to the rule location.
>>  * @location: Location of rule in the table.  Locations must be
>>  *	numbered such that a flow matching multiple rules will be
>>  *	classified according to the first (lowest numbered) rule.
> 
> I'm aware, Gal, but the question is whether every driver developer 
> is aware of this, not just me and perhaps you.
> 
>> The cited patch is a regression from user's perspective. Surely, not an
>> intended one?
> 
> I believe this message should already answer you questions:
> https://lore.kernel.org/all/20250226204503.77010912@kernel.org/
> Fix the commit message, add test, repost.

This is a bug fix targeted for net; the test should be submitted as
net-next material

Just to confirm, are you making test addition a prerequisite to merge a
bug fix?