netdev - Re: [PATCH 3/3] net: ipa: Enable checksum for IPA_ENDPOINT_AP_MODEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2246f041-3e42-4534-bf89-3630ca2426d1@ieee.org>
Date: Tue, 4 Mar 2025 10:50:15 -0600
From: Alex Elder <elder@...e.org>
To: Luca Weiss <luca.weiss@...rphone.com>, Alex Elder <elder@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] net: ipa: Enable checksum for
 IPA_ENDPOINT_AP_MODEM_{RX,TX} for v4.7

On 2/27/25 4:33 AM, Luca Weiss wrote:
> Enable the checksum option for these two endpoints in order to allow
> mobile data to actually work. Without this, no packets seem to make it
> through the IPA.
> 
> Fixes: b310de784bac ("net: ipa: add IPA v4.7 support")
> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>

This makes sense.  The checksum option affects how outgoing
packets are formatted and incoming packets are interpreted
by the IPA hardware.  So with this being wrong, I suppose
packets (one way and/or the other) might just be getting
dropped as invalid.

This looks good to me.  I'm really pleased you were able to
get this working.

Reviewed-by: Alex Elder <elder@...cstar.com>

> ---
>   drivers/net/ipa/data/ipa_data-v4.7.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ipa/data/ipa_data-v4.7.c b/drivers/net/ipa/data/ipa_data-v4.7.c
> index e63dcf8d45567b0851393c2cea7a0d630afa20cd..41f212209993f10fee338e28027739a7402d5089 100644
> --- a/drivers/net/ipa/data/ipa_data-v4.7.c
> +++ b/drivers/net/ipa/data/ipa_data-v4.7.c
> @@ -104,6 +104,7 @@ static const struct ipa_gsi_endpoint_data ipa_gsi_endpoint_data[] = {
>   			.filter_support	= true,
>   			.config = {
>   				.resource_group	= IPA_RSRC_GROUP_SRC_UL_DL,
> +				.checksum       = true,
>   				.qmap		= true,
>   				.status_enable	= true,
>   				.tx = {
> @@ -127,6 +128,7 @@ static const struct ipa_gsi_endpoint_data ipa_gsi_endpoint_data[] = {
>   		.endpoint = {
>   			.config = {
>   				.resource_group	= IPA_RSRC_GROUP_DST_UL_DL,
> +				.checksum       = true,
>   				.qmap		= true,
>   				.aggregation	= true,
>   				.rx = {
>