netdev - Re: [PATCH net-next 1/4] tcp: use RCU in __inet{6}_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250304002044.60686-1-kuniyu@amazon.com>
Date: Mon, 3 Mar 2025 16:20:44 -0800
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <edumazet@...gle.com>
CC: <davem@...emloft.net>, <eric.dumazet@...il.com>, <horms@...nel.org>,
	<kerneljasonxing@...il.com>, <kuba@...nel.org>, <kuniyu@...zon.com>,
	<ncardwell@...gle.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH net-next 1/4] tcp: use RCU in __inet{6}_check_established()

From: Eric Dumazet <edumazet@...gle.com>
Date: Sun,  2 Mar 2025 12:42:34 +0000
> When __inet_hash_connect() has to try many 4-tuples before
> finding an available one, we see a high spinlock cost from
> __inet_check_established() and/or __inet6_check_established().
> 
> This patch adds an RCU lookup to avoid the spinlock
> acquisition when the 4-tuple is found in the hash table.
> 
> Note that there are still spin_lock_bh() calls in
> __inet_hash_connect() to protect inet_bind_hashbucket,
> this will be fixed later in this series.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reviewed-by: Jason Xing <kerneljasonxing@...il.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>