netdev - Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: add internal-PHY-to-PHY CPU link example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TYZPR01MB5556CB47BC21C5015F698CA4C9CB2@TYZPR01MB5556.apcprd01.prod.exchangelabs.com>
Date: Wed, 5 Mar 2025 22:41:00 +0800
From: Ziyang Huang <hzyitc@...look.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: "olteanv@...il.com" <olteanv@...il.com>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>,
 "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "rmk+kernel@...linux.org.uk" <rmk+kernel@...linux.org.uk>,
 "javier.carrasco.cruz@...il.com" <javier.carrasco.cruz@...il.com>,
 "john@...ozen.org" <john@...ozen.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: add internal-PHY-to-PHY
 CPU link example

在 2025/3/4 22:11, Andrew Lunn 写道:
>> (Port0 and Port6). Could I just keep this or should I need to add a new
>> case ?
> 
> The existing examples are probably sufficient. Just check the text to
> make sure it does not limit it to ports 0 and 6.
> 
>>> So is this actually internally? Or do you have a IPQ50xx SoC connected
>>> to a qca8337 switch, with copper traces on a PCB? If so, it is not
>>> internal.
>>
>> The "internal" is used to describe the localcation of PHY not the link.
>> In current code, qca8k has supported to use a external PHY to do a
>> PHY-to-PHY link (Port0 and Port6). This patch make the internal PHYs
>> support it too (Port1-5).
>>
>> The followiing topology is existed in most IPQ50xx-based router:
>>      _______________________         _______________________
>>     |        IPQ5018        |       |        QCA8337        |
>>     | +------+   +--------+ |       | +--------+   +------+ |
>>     | | MAC0 |---| GE Phy |-+--MDI--+-|  Phy4  |---| MAC5 | |
>>     | +------+   +--------+ |       | +--------+   +------+ |
>>     | +------+   +--------+ |       | +--------+   +------+ |
>>     | | MAC1 |---| Uniphy |-+-SGMII-+-| SerDes |---| MAC0 | |
>>     | +------+   +--------+ |       | +--------+   +------+ |
>>     |_______________________|       |_______________________|
> 
> So logically, it does not matter if the PHY is internal or
> external. The patch would be the same. I've even see setups where the
> SGMII link would have a PHY, then a connection to a daughter board,
> and then a PHY back to SGMII before connecting to the switch. Running
> Ethernet over the connector is easier than SERDES lines.
> 
> So i would probably drop the word internal from this discussion,
> unless it is really relevant.
> 
> 	Andrew

Ok, will remove the word in next patch