netdev - Re: [PATCH] sched: address a potential NULL pointer dereference in the GRED scheduler.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <DB9B87BD-C829-4A06-B692-77324096AF4F@gmail.com>
Date: Wed, 5 Mar 2025 23:57:44 +0800
From: Jun Yang <juny24602@...il.com>
To: xiyou.wangcong@...il.com
Cc: juny24602@...il.com,
 netdev@...r.kernel.org
Subject: Re: [PATCH] sched: address a potential NULL pointer dereference in
 the GRED scheduler.

On Wed, Mar 5, 2025 at 4:05 AM Cong Wang <xiyou.wangcong@...il.com> wrote:
> I think the whole gred_offload() should be skipped when table->opt ==
> NULL, espeically the last call of ->ndo_setup_tc(). Something like:

Thank you for your review. I have updated the part with my name.
I don't quite understand why the code would send a TC_SETUP_QDISC_GRED command during destroy. I haven't found the function that handles this command, so this part of the code should not produce side effects. Adding a check on the outer layer would indeed be safer. I have already modified this part of the patch.