netdev - Re: [PATCH net-next] net/mlnx5: Use generic code for page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <433b43b1-0a42-4606-b919-3429c36aa934@lunn.ch>
Date: Wed, 5 Mar 2025 17:21:56 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Joe Damato <jdamato@...tly.com>,
	Leon Romanovsky <leon@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Saeed Mahameed <saeedm@...dia.com>,
	Tariq Toukan <tariqt@...dia.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH net-next] net/mlnx5: Use generic code for page_pool
 statistics.

> @@ -276,6 +263,9 @@ static MLX5E_DECLARE_STATS_GRP_OP_FILL_STATS(sw)
>  		mlx5e_ethtool_put_stat(data,
>  				       MLX5E_READ_CTR64_CPU(&priv->stats.sw,
>  							    sw_stats_desc, i));
> +#ifdef CONFIG_PAGE_POOL_STATS
> +	*data = page_pool_ethtool_stats_get(*data, &priv->stats.sw.page_pool_stats);
> +#endif
>  }

Are these #ifdef required? include/net/page_pool/helpers.h:

static inline u64 *page_pool_ethtool_stats_get(u64 *data, const void *stats)
{
	return data;
}

Seems silly to have a stub if it cannot be used.

	Andrew