netdev - Re: [PATCH net-next 1/2] selftests: net: fix error message in bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8eWZSuDU4Q4q5UM@mini-arch>
Date: Tue, 4 Mar 2025 16:10:13 -0800
From: Stanislav Fomichev <stfomichev@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
	shuah@...nel.org, linux-kselftest@...r.kernel.org,
	bpf@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] selftests: net: fix error message in
 bpf_offload

On 03/04, Jakub Kicinski wrote:
> We hit a following exception on timeout, nmaps is never set:
> 
>     Test bpftool bound info reporting (own ns)...
>     Traceback (most recent call last):
>       File "/home/virtme/testing-1/tools/testing/selftests/net/./bpf_offload.py", line 1128, in <module>
>         check_dev_info(False, "")
>       File "/home/virtme/testing-1/tools/testing/selftests/net/./bpf_offload.py", line 583, in check_dev_info
>         maps = bpftool_map_list_wait(expected=2, ns=ns)
>       File "/home/virtme/testing-1/tools/testing/selftests/net/./bpf_offload.py", line 215, in bpftool_map_list_wait
>         raise Exception("Time out waiting for map counts to stabilize want %d, have %d" % (expected, nmaps))
>     NameError: name 'nmaps' is not defined
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Acked-by: Stanislav Fomichev <sdf@...ichev.me>

I've seen this a couple of times myself but was too lazy to send out
a fix :-[