netdev - Re: [PATCH iwl-next v3] igc: Change Tx mode for MQPRIO offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a59zc2od.fsf@kurt.kurt.home>
Date: Wed, 05 Mar 2025 09:16:50 +0100
From: Kurt Kanzenbach <kurt@...utronix.de>
To: Simon Horman <horms@...nel.org>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Faizal Rahim
 <faizal.abdul.rahim@...ux.intel.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Subject: Re: [PATCH iwl-next v3] igc: Change Tx mode for MQPRIO offloading

On Tue Mar 04 2025, Simon Horman wrote:
> On Mon, Mar 03, 2025 at 10:16:33AM +0100, Kurt Kanzenbach wrote:
>> The current MQPRIO offload implementation uses the legacy TSN Tx mode. In
>> this mode the hardware uses four packet buffers and considers queue
>> priorities.
>> 
>> In order to harmonize the TAPRIO implementation with MQPRIO, switch to the
>> regular TSN Tx mode. This mode also uses four packet buffers and considers
>> queue priorities. In addition to the legacy mode, transmission is always
>> coupled to Qbv. The driver already has mechanisms to use a dummy schedule
>> of 1 second with all gates open for ETF. Simply use this for MQPRIO too.
>> 
>> This reduces code and makes it easier to add support for frame preemption
>> later.
>> 
>> While at it limit the netdev_tc calls to MQPRIO only.
>
> Hi Kurt,
>
> Can this part be broken out into a separate patch?
> It seems so to me, but perhaps I'm missing something.
>
> The reason that I ask is that this appears to be a good portion of the
> change, and doing so would make the code changes for main part of the
> patch, as per the description prior to the line above, clearer IMHO.

Sure, i think it can be broken out into a dedicated patch. I'll see what
I can come up with.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)