netdev - Re: [PATCH] net: marvell: mvmdio: Add missing function argument name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f2c4478-cbb1-4c68-b980-d6e07a7b971a@redhat.com>
Date: Thu, 6 Mar 2025 10:55:31 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Vinitha Vijayan <vinithamvijayan723@...il.com>,
 "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
 "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>,
 "kuba@...nel.org" <kuba@...nel.org>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: marvell: mvmdio: Add missing function argument name

On 3/4/25 8:58 PM, Vinitha Vijayan wrote:
> Fix a coding style issue in mvmdio.c where a function definition argument `struct orion_mdio_dev *` was missing an identifier name. This aligns with Linux kernel coding standards.
> 
> Signed-off-by: Vinitha <vinithamvijayan723@...il.com<mailto:vinithamvijayan723@...il.com>>

The patch does not apply, the commit message is not trimmed at 72
colums, and the SoB tag is mangled.

More importantly, this kind of purely formal refactor should be part of
larger/functional changes.

I'm sorry, this patch is not going to be applied.

Cheers,

Paolo